Hi!
On Mon, 10 Feb 2014 00:42:54 +0100, Tobias Burnus bur...@net-b.de wrote:
Some general questions to the patch set:
Thanks for helping review!
* I miss -fopenacc. Is the support already in the branch? I assume
that part is then in c-family/c.opt fortran/lang.opt?
* Documentation: Do
Hi Thomas!
On 10.02.2014 12:52, Thomas Schwinge wrote:
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/goacc/goacc.exp
@@ -0,0 +1,36 @@
+# Load support procs.
+load_lib gfortran-dg.exp
+
+if ![check_effective_target_fopenmp] {
+ return
+}
I assume that this should be indeed fopenmp here and not
Hi Tobias!
Thanks a lot for your review!
I'm going to test you notes in reference implementation (PGI
compiler), and then share the results.
On 10.02.2014 03:42, Tobias Burnus wrote:
Is there a reason that you don't automatically add that flag via
goacc.exp?
Ditto. Also spaces before/after
Hi!
On Mon, 10 Feb 2014 13:44:51 +0400, Ilmir Usmanov i.usma...@samsung.com wrote:
As -fopenmp seemingly can be mixed with -fopenacc, I think it would be
nice to have some test cases where !$omp and !$acc are both placed -
in either order - before the same Fortran statement.
I'm going
Hi!
Thomas Schwinge wrote:
Please see
[...]
$ git diff --stat 765faa80eda3bb75aa044ad015e2e5214bf02c6d
origin/gomp-4_0-branch | grep -v ChangeLog
I am now browsing through the changes. Remarks:
1) I think you also want to set in gcc/fortran/options.c
gfc_option.flag_recursive = -1
Some general questions to the patch set:
* I miss -fopenacc. Is the support already in the branch? I assume
that part is then in c-family/c.opt fortran/lang.opt?
* Documentation: Do you also need to update fortran/gfortran.texi and/or
fortran/invoke.texi? (I assume that -fopenacc is already
OpenACC 1.0 fortran FE support -- tests.
gcc/testsuite/gfortran.dg/goacc/
* goacc.exp: New test directory.
* branch.f95: New test.
* continuation-free-form.f95: Likewise.
* data-clauses.f95: Likewise.
* data-tree.f95: Likewise.
* declare-1.f95: Likewise.
*
From ae0ba17c51f6ed3529976a0cdf8f80046d1ed9b7 Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Thu, 23 Jan 2014 21:10:41 +0400
Subject: [PATCH 5/6] OpenACC fortran tests
---
gcc/testsuite/gfortran.dg/goacc/branch.f95 | 55 +
