Re: [PATCH 5/9] Come up with an abstraction.

2019-09-19 Thread Richard Biener
On Wed, Sep 18, 2019 at 9:56 AM Martin Liška wrote: > > Hello. > > Ok, so the current IPA ICF transformation is being blocked by the > patch 2/9 (about FIELD_DECL). I asked Honza for a help here. > In the meantime, can you Richi make an opinion about the part 5 which > is about the interaction in

Re: [PATCH 5/9] Come up with an abstraction.

2019-09-18 Thread Martin Liška
Hello. Ok, so the current IPA ICF transformation is being blocked by the patch 2/9 (about FIELD_DECL). I asked Honza for a help here. In the meantime, can you Richi make an opinion about the part 5 which is about the interaction in between old operand_equal_p and a new hook in IPA ICF? Thanks,

Re: [PATCH 5/9] Come up with an abstraction.

2019-08-16 Thread Martin Liška
? ICF would call deriv::operand_equal_p and > base::operand_equal_p would recurse via the derived implementation. > > That at least is cleaner from the "looks". LGTM, I'm sending updated for to address that. > >>> But the same could be achieved by actually making t1 and

Re: [PATCH 5/9] Come up with an abstraction.

2019-08-14 Thread Richard Biener
On Wed, Aug 14, 2019 at 3:19 PM Martin Liška wrote: > > On 8/14/19 3:04 PM, Richard Biener wrote: > > On Mon, Aug 12, 2019 at 3:56 PM Martin Liška wrote: > >> > >> On 8/12/19 2:43 PM, Richard Biener wrote: > >>> On Mon, Aug 12, 2019 at 1:49 PM Martin Liška wrote: > > On 8/12/19 1:40

Re: [PATCH 5/9] Come up with an abstraction.

2019-08-14 Thread Martin Liška
On 8/14/19 3:04 PM, Richard Biener wrote: > On Mon, Aug 12, 2019 at 3:56 PM Martin Liška wrote: >> >> On 8/12/19 2:43 PM, Richard Biener wrote: >>> On Mon, Aug 12, 2019 at 1:49 PM Martin Liška wrote: On 8/12/19 1:40 PM, Richard Biener wrote: > On Mon, Aug 12, 2019 at 1:19 PM Martin

Re: [PATCH 5/9] Come up with an abstraction.

2019-08-14 Thread Richard Biener
On Mon, Aug 12, 2019 at 3:56 PM Martin Liška wrote: > > On 8/12/19 2:43 PM, Richard Biener wrote: > > On Mon, Aug 12, 2019 at 1:49 PM Martin Liška wrote: > >> > >> On 8/12/19 1:40 PM, Richard Biener wrote: > >>> On Mon, Aug 12, 2019 at 1:19 PM Martin Liška wrote: > > On 8/8/19 5:55

Re: [PATCH 5/9] Come up with an abstraction.

2019-08-12 Thread Martin Liška
On 8/12/19 2:43 PM, Richard Biener wrote: > On Mon, Aug 12, 2019 at 1:49 PM Martin Liška wrote: >> >> On 8/12/19 1:40 PM, Richard Biener wrote: >>> On Mon, Aug 12, 2019 at 1:19 PM Martin Liška wrote: On 8/8/19 5:55 PM, Michael Matz wrote: > Hi, > > On Mon, 10 Jun 2019,

Re: [PATCH 5/9] Come up with an abstraction.

2019-08-12 Thread Michael Matz
Hi, On Mon, 12 Aug 2019, Martin Liška wrote: > > You seem to need it only to have the possibility of virtual functions, > > i.e. fancy callbacks. AFAICS you only have one derived class, i.e. a > > simple distinction of two cases. What do you think about encoding the > > additional new (ICF)

Re: [PATCH 5/9] Come up with an abstraction.

2019-08-12 Thread Richard Biener
On Mon, Aug 12, 2019 at 1:49 PM Martin Liška wrote: > > On 8/12/19 1:40 PM, Richard Biener wrote: > > On Mon, Aug 12, 2019 at 1:19 PM Martin Liška wrote: > >> > >> On 8/8/19 5:55 PM, Michael Matz wrote: > >>> Hi, > >>> > >>> On Mon, 10 Jun 2019, Martin Liska wrote: > >>> > 2019-07-24

Re: [PATCH 5/9] Come up with an abstraction.

2019-08-12 Thread Martin Liška
On 8/12/19 1:40 PM, Richard Biener wrote: > On Mon, Aug 12, 2019 at 1:19 PM Martin Liška wrote: >> >> On 8/8/19 5:55 PM, Michael Matz wrote: >>> Hi, >>> >>> On Mon, 10 Jun 2019, Martin Liska wrote: >>> 2019-07-24 Martin Liska * fold-const.c (operand_equal_p): Rename to ...

Re: [PATCH 5/9] Come up with an abstraction.

2019-08-12 Thread Richard Biener
On Mon, Aug 12, 2019 at 1:19 PM Martin Liška wrote: > > On 8/8/19 5:55 PM, Michael Matz wrote: > > Hi, > > > > On Mon, 10 Jun 2019, Martin Liska wrote: > > > >> 2019-07-24 Martin Liska > >> > >> * fold-const.c (operand_equal_p): Rename to ... > >> (operand_compare::operand_equal_p):

Re: [PATCH 5/9] Come up with an abstraction.

2019-08-12 Thread Martin Liška
On 8/8/19 5:55 PM, Michael Matz wrote: > Hi, > > On Mon, 10 Jun 2019, Martin Liska wrote: > >> 2019-07-24 Martin Liska >> >> * fold-const.c (operand_equal_p): Rename to ... >> (operand_compare::operand_equal_p): ... this. >> (add_expr): Rename to ... >>

Re: [PATCH 5/9] Come up with an abstraction.

2019-08-09 Thread Richard Biener
On Tue, Aug 6, 2019 at 5:44 PM Martin Liska wrote: > > > gcc/ChangeLog: Hum. I don't like the "abstraction" - how is it going to help you to not duplicate all the code? What's wrong with doing this all in ICF? Richard. > 2019-07-24 Martin Liska > > * fold-const.c

Re: [PATCH 5/9] Come up with an abstraction.

2019-08-08 Thread Michael Matz
Hi, On Mon, 10 Jun 2019, Martin Liska wrote: > 2019-07-24 Martin Liska > > * fold-const.c (operand_equal_p): Rename to ... > (operand_compare::operand_equal_p): ... this. > (add_expr): Rename to ... > (operand_compare::hash_operand): ... this. >

[PATCH 5/9] Come up with an abstraction.

2019-08-06 Thread Martin Liska
gcc/ChangeLog: 2019-07-24 Martin Liska * fold-const.c (operand_equal_p): Rename to ... (operand_compare::operand_equal_p): ... this. (add_expr): Rename to ... (operand_compare::hash_operand): ... this. (operand_compare::operand_equal_valueize):