Re: [PATCH 6/6] rs6000: Clean up the various rlwinm patterns

2015-05-11 Thread David Edelsohn
On Sun, May 10, 2015 at 12:13 PM, Segher Boessenkool seg...@kernel.crashing.org wrote: Some cleanups: * Give every define_insn a name; * Add missing conditions for some of the dot forms; * Use define_insn_and_split to reduce duplication; * Renumber operands so 0,1,2,3 are the actual operands

Re: [PATCH 6/6] rs6000: Clean up the various rlwinm patterns

2015-05-11 Thread Maciej W. Rozycki
On Sun, 10 May 2015, Segher Boessenkool wrote: This clearly renames rather than removing the `rlwinm' pattern, please correctly reflect that in ChangeLog. Some other, unnamed patterns are given names rather than deleted as well, just as you've noted at the top. And none of the other

Re: [PATCH 6/6] rs6000: Clean up the various rlwinm patterns

2015-05-10 Thread Maciej W. Rozycki
On Sun, 10 May 2015, Segher Boessenkool wrote: * Give every define_insn a name; * Add missing conditions for some of the dot forms; * Use define_insn_and_split to reduce duplication; * Renumber operands so 0,1,2,3 are the actual operands of the machine instruction, in order; * Reformat

[PATCH 6/6] rs6000: Clean up the various rlwinm patterns

2015-05-10 Thread Segher Boessenkool
Some cleanups: * Give every define_insn a name; * Add missing conditions for some of the dot forms; * Use define_insn_and_split to reduce duplication; * Renumber operands so 0,1,2,3 are the actual operands of the machine instruction, in order; * Reformat some patterns. Is this okay for trunk?

Re: [PATCH 6/6] rs6000: Clean up the various rlwinm patterns

2015-05-10 Thread Segher Boessenkool
On Sun, May 10, 2015 at 07:02:33PM +0100, Maciej W. Rozycki wrote: -(define_insn rlwinm +(define_insn *ashlsi3_imm_mask [(set (match_operand:SI 0 gpc_reg_operand =r) (and:SI (ashift:SI (match_operand:SI 1 gpc_reg_operand r) (match_operand:SI 2