Re: [PATCH 7/7] Expand directly for single bit test

2023-05-21 Thread David Edelsohn via Gcc-patches
On Sun, May 21, 2023 at 11:25 AM Andrew Pinski wrote: > On Sun, May 21, 2023 at 11:17 AM David Edelsohn via Gcc-patches > wrote: > > > > Hi, Andrew > > > > Thanks for this series of patches to improve do_store_flag. > Unfortunately > > this specific patch in the series has caused a bootstrap

Re: [PATCH 7/7] Expand directly for single bit test

2023-05-21 Thread Jeff Law via Gcc-patches
On 5/21/23 12:25, Andrew Pinski via Gcc-patches wrote: On Sun, May 21, 2023 at 11:17 AM David Edelsohn via Gcc-patches wrote: Hi, Andrew Thanks for this series of patches to improve do_store_flag. Unfortunately this specific patch in the series has caused a bootstrap failure on

Re: [PATCH 7/7] Expand directly for single bit test

2023-05-21 Thread Andrew Pinski via Gcc-patches
On Sun, May 21, 2023 at 11:25 AM Andrew Pinski wrote: > > On Sun, May 21, 2023 at 11:17 AM David Edelsohn via Gcc-patches > wrote: > > > > Hi, Andrew > > > > Thanks for this series of patches to improve do_store_flag. Unfortunately > > this specific patch in the series has caused a bootstrap

Re: [PATCH 7/7] Expand directly for single bit test

2023-05-21 Thread Andrew Pinski via Gcc-patches
On Sun, May 21, 2023 at 11:17 AM David Edelsohn via Gcc-patches wrote: > > Hi, Andrew > > Thanks for this series of patches to improve do_store_flag. Unfortunately > this specific patch in the series has caused a bootstrap failure on > powerpc-aix. I bisected this failure to this specific

Re: [PATCH 7/7] Expand directly for single bit test

2023-05-21 Thread David Edelsohn via Gcc-patches
Hi, Andrew Thanks for this series of patches to improve do_store_flag. Unfortunately this specific patch in the series has caused a bootstrap failure on powerpc-aix. I bisected this failure to this specific patch. Note that I am building as 32 bit, so this could be a specific issue about bit

Re: [PATCH 7/7] Expand directly for single bit test

2023-05-19 Thread Jeff Law via Gcc-patches
On 5/19/23 20:14, Andrew Pinski via Gcc-patches wrote: Instead of using creating trees to the expansion, just expand directly which makes the code a little simplier but also reduces how much GC memory will be used during the expansion. OK? Bootstrapped and tested on x86_64-linux.

[PATCH 7/7] Expand directly for single bit test

2023-05-19 Thread Andrew Pinski via Gcc-patches
Instead of using creating trees to the expansion, just expand directly which makes the code a little simplier but also reduces how much GC memory will be used during the expansion. OK? Bootstrapped and tested on x86_64-linux. gcc/ChangeLog: * expr.cc (fold_single_bit_test): Rename to