> -Original Message-
> From: Richard Biener
> Sent: Thursday, December 14, 2023 1:13 PM
> To: Tamar Christina
> Cc: Richard Sandiford ; gcc-patches@gcc.gnu.org;
> nd ; j...@ventanamicro.com
> Subject: RE: [PATCH 9/21]middle-end: implement vectorizable_early_exit
On Wed, 13 Dec 2023, Tamar Christina wrote:
> > > > else if (vect_use_mask_type_p (stmt_info))
> > > > {
> > > > unsigned int precision = stmt_info->mask_precision;
> > > > scalar_type = build_nonstandard_integer_type (precision, 1);
> > > > vectype = get_mask_type_for_scal
> > > else if (vect_use_mask_type_p (stmt_info))
> > > {
> > > unsigned int precision = stmt_info->mask_precision;
> > > scalar_type = build_nonstandard_integer_type (precision, 1);
> > > vectype = get_mask_type_for_scalar_type (vinfo, scalar_type,
> > > group_size);
> > >
On Tue, 12 Dec 2023, Richard Sandiford wrote:
> Richard Biener writes:
> > On Mon, 11 Dec 2023, Tamar Christina wrote:
> >> @@ -5553,6 +5554,83 @@ integer_type_for_mask (tree var, vec_info *vinfo)
> >>return build_nonstandard_integer_type (def_stmt_info->mask_precision,
> >> 1);
> >> }
> >>
Richard Biener writes:
> On Mon, 11 Dec 2023, Tamar Christina wrote:
>> @@ -5553,6 +5554,83 @@ integer_type_for_mask (tree var, vec_info *vinfo)
>>return build_nonstandard_integer_type (def_stmt_info->mask_precision, 1);
>> }
>>
>> +/* Function vect_recog_gcond_pattern
>> +
>> + Try to fi
> -Original Message-
> From: Richard Biener
> Sent: Tuesday, December 12, 2023 10:10 AM
> To: Tamar Christina
> Cc: gcc-patches@gcc.gnu.org; nd ; j...@ventanamicro.com;
> Richard Sandiford
> Subject: RE: [PATCH 9/21]middle-end: implement vectorizable_early_exit
On Mon, 11 Dec 2023, Tamar Christina wrote:
> > > + vectype = truth_type_for (comp_type);
> >
> > so this leaves the producer of the mask in the GIMPLE_COND and we
> > vectorize the GIMPLE_COND as
> >
> > mask_1 = ...;
> > if (mask_1 != {-1,-1...})
> > ..
> >
> > ? In principle only
> > + vectype = truth_type_for (comp_type);
>
> so this leaves the producer of the mask in the GIMPLE_COND and we
> vectorize the GIMPLE_COND as
>
> mask_1 = ...;
> if (mask_1 != {-1,-1...})
> ..
>
> ? In principle only the mask producer needs a vector type and that
> adjusted by bo
On Mon, 11 Dec 2023, Tamar Christina wrote:
> > > >
> > > > Hmm, but we're visiting them then? I wonder how you get along
> > > > without doing adjustmens on the uses if you consider
> > > >
> > > > _1 = a < b;
> > > > _2 = c != d;
> > > > _3 = _1 | _2;
> > > > if (_3 != 0)
> > >
> > >
> > > Hmm, but we're visiting them then? I wonder how you get along
> > > without doing adjustmens on the uses if you consider
> > >
> > > _1 = a < b;
> > > _2 = c != d;
> > > _3 = _1 | _2;
> > > if (_3 != 0)
> > > exit loop;
> > >
> > > thus a combined condition like
>
> -Original Message-
> From: Richard Biener
> Sent: Friday, December 8, 2023 2:00 PM
> To: Tamar Christina
> Cc: gcc-patches@gcc.gnu.org; nd ; j...@ventanamicro.com
> Subject: RE: [PATCH 9/21]middle-end: implement vectorizable_early_exit for
> codegen of exit code
&g
On Fri, 8 Dec 2023, Tamar Christina wrote:
> > -Original Message-
> > From: Richard Biener
> > Sent: Friday, December 8, 2023 10:28 AM
> > To: Tamar Christina
> > Cc: gcc-patches@gcc.gnu.org; nd ; j...@ventanamicro.com
> > Subject: R
> -Original Message-
> From: Richard Biener
> Sent: Friday, December 8, 2023 10:28 AM
> To: Tamar Christina
> Cc: gcc-patches@gcc.gnu.org; nd ; j...@ventanamicro.com
> Subject: RE: [PATCH 9/21]middle-end: implement vectorizable_early_exit for
> codegen of exit co
On Fri, 8 Dec 2023, Tamar Christina wrote:
> > --param vect-partial-vector-usage=2 would, no?
> >
> I.. didn't even know it went to 2!
>
> > > In principal I suppose I could mask the individual stmts, that should
> > > handle the
> > future case when
> > > This is relaxed to supposed non-fix le
> --param vect-partial-vector-usage=2 would, no?
>
I.. didn't even know it went to 2!
> > In principal I suppose I could mask the individual stmts, that should
> > handle the
> future case when
> > This is relaxed to supposed non-fix length buffers?
>
> Well, it looks wrong - either put in an a
On Wed, 6 Dec 2023, Tamar Christina wrote:
> > > > +
> > > > + tree truth_type = truth_type_for (vectype_op); machine_mode mode =
> > > > + TYPE_MODE (truth_type); int ncopies;
> > > > +
> >
> > more line break issues ... (also below, check yourself)
> >
> > shouldn't STMT_VINFO_VECTYPE alrea
> > > +
> > > + tree truth_type = truth_type_for (vectype_op); machine_mode mode =
> > > + TYPE_MODE (truth_type); int ncopies;
> > > +
>
> more line break issues ... (also below, check yourself)
>
> shouldn't STMT_VINFO_VECTYPE already match truth_type here? If not
> it looks to be set wrong
ubject: RE: RE: [PATCH 9/21]middle-end: implement vectorizable_early_exit for codegen of exit code
Hi Juzhe,
I meant that “lens” is undefined, from looking around I guess that needs to be
vec_loop_lens *lens = &LOOP_VINFO_LENS (loop_vinfo);
for `bias` I meant
cond = gimple_build
s.
>
> --
> juzhe.zh...@rivai.ai
>
>
> *From:* Tamar Christina
> *Date:* 2023-11-30 18:58
> *To:* juzhe.zh...@rivai.ai; gcc-patches
> *CC:* Richard Biener
> *Subject:* RE: RE: [PATCH 9/21]middle-end: implement
> vectorizable_early_exit for
From: Tamar Christina
Date: 2023-11-30 18:58
To: juzhe.zh...@rivai.ai; gcc-patches
CC: Richard Biener
Subject: RE: RE: [PATCH 9/21]middle-end: implement vectorizable_early_exit for
codegen of exit code
Hi Juzhe,
I meant that “lens” is undefined, from looking around I guess that needs to be
na ; gcc-patches
Cc: Richard Biener
Subject: Re: RE: [PATCH 9/21]middle-end: implement vectorizable_early_exit for
codegen of exit code
Thanks Tamar.
I am not sure whether I am not on the same page with you.
IMHO, ARM SVE will use the final mask = loop mask (generate by WHILE_ULT) &
condition
ar Christina
Date: 2023-11-30 18:39
To: juzhe.zh...@rivai.ai; gcc-patches
CC: Richard Biener
Subject: RE: [PATCH 9/21]middle-end: implement vectorizable_early_exit for
codegen of exit code
Hi Juzhe,
I’m happy to take the hunks, just that I can’t test it and don’t know the
specifics of how it
ll also need what to do for vectorizable_live_operations how to get the first
element rather than the last.
Thanks,
Tamar
From: juzhe.zh...@rivai.ai
Sent: Thursday, November 30, 2023 4:48 AM
To: gcc-patches
Cc: Richard Biener ; Tamar Christina
Subject: [PATCH 9/21]middle-end: implement vec
Hi, Richard and Tamar.
I am sorry for bothering you.
Hope you don't mind I give some comments:
Can we support partial vector for length ?
IMHO, we can do that as follows:
bool length_loop_p = LOOP_VINFO_FULLY_WITH_LENGTH_P (loop_vinfo);
if (LOOP_VINFO_CAN_USE_PARTIAL_VECTORS_P (loop_vinfo))
On Mon, 27 Nov 2023, Tamar Christina wrote:
> Ping
>
> > -Original Message-
> > From: Tamar Christina
> > Sent: Monday, November 6, 2023 7:40 AM
> > To: gcc-patches@gcc.gnu.org
> > Cc: nd ; rguent...@suse.de; j...@ventanamicro.com
> >
Ping
> -Original Message-
> From: Tamar Christina
> Sent: Monday, November 6, 2023 7:40 AM
> To: gcc-patches@gcc.gnu.org
> Cc: nd ; rguent...@suse.de; j...@ventanamicro.com
> Subject: [PATCH 9/21]middle-end: implement vectorizable_early_exit for
> codegen of
Hi All,
This implements vectorable_early_exit which is used as the codegen part of
vectorizing a gcond.
For the most part it shares the majority of the code with
vectorizable_comparison with addition that it needs to be able to reduce
multiple resulting statements into a single one for use in the
27 matches
Mail list logo
