Re: [PATCH GCC]A simple implementation of loop interchange

2017-11-23 Thread Bin.Cheng
Hi Richard, Thanks for reviewing. It's quite lot comment, I am trying to resolve it one by one. Here I have some questions as embedded. On Mon, Nov 20, 2017 at 2:46 PM, Richard Biener wrote: > On Thu, Nov 16, 2017 at 4:18 PM, Bin.Cheng wrote:

Re: [PATCH GCC]A simple implementation of loop interchange

2017-11-20 Thread Richard Biener
On Thu, Nov 16, 2017 at 4:18 PM, Bin.Cheng wrote: > On Tue, Oct 24, 2017 at 3:30 PM, Michael Matz wrote: >> Hello, >> >> On Fri, 22 Sep 2017, Bin.Cheng wrote: >> >>> This is updated patch for loop interchange with review suggestions >>> resolved. Changes

Re: [PATCH GCC]A simple implementation of loop interchange

2017-11-16 Thread Bin.Cheng
On Tue, Oct 24, 2017 at 3:30 PM, Michael Matz wrote: > Hello, > > On Fri, 22 Sep 2017, Bin.Cheng wrote: > >> This is updated patch for loop interchange with review suggestions >> resolved. Changes are: >> 1) It does more light weight checks like rectangle loop nest check >>

Re: [PATCH GCC]A simple implementation of loop interchange

2017-10-24 Thread Michael Matz
Hello, On Fri, 22 Sep 2017, Bin.Cheng wrote: > This is updated patch for loop interchange with review suggestions > resolved. Changes are: > 1) It does more light weight checks like rectangle loop nest check > earlier than before. > 2) It checks profitability of interchange before data

Re: [PATCH GCC]A simple implementation of loop interchange

2017-09-22 Thread Bin.Cheng
On Mon, Sep 4, 2017 at 2:54 PM, Richard Biener wrote: > On Wed, Aug 30, 2017 at 6:32 PM, Bin.Cheng wrote: >> On Wed, Aug 30, 2017 at 3:19 PM, Richard Biener >> wrote: >>> On Wed, Aug 30, 2017 at 3:18 PM, Bin Cheng

Re: [PATCH GCC]A simple implementation of loop interchange

2017-09-04 Thread Bin.Cheng
On Mon, Sep 4, 2017 at 2:54 PM, Richard Biener wrote: > On Wed, Aug 30, 2017 at 6:32 PM, Bin.Cheng wrote: >> On Wed, Aug 30, 2017 at 3:19 PM, Richard Biener >> wrote: >>> On Wed, Aug 30, 2017 at 3:18 PM, Bin Cheng

Re: [PATCH GCC]A simple implementation of loop interchange

2017-09-04 Thread Richard Biener
On Wed, Aug 30, 2017 at 6:32 PM, Bin.Cheng wrote: > On Wed, Aug 30, 2017 at 3:19 PM, Richard Biener > wrote: >> On Wed, Aug 30, 2017 at 3:18 PM, Bin Cheng wrote: >>> Hi, >>> This patch implements a simple loop interchange

Re: [PATCH GCC]A simple implementation of loop interchange

2017-08-30 Thread Bin.Cheng
On Wed, Aug 30, 2017 at 3:19 PM, Richard Biener wrote: > On Wed, Aug 30, 2017 at 3:18 PM, Bin Cheng wrote: >> Hi, >> This patch implements a simple loop interchange pass in GCC, as described by >> its comments: >> +/* This pass performs loop

Re: [PATCH GCC]A simple implementation of loop interchange

2017-08-30 Thread Richard Biener
On Wed, Aug 30, 2017 at 3:18 PM, Bin Cheng wrote: > Hi, > This patch implements a simple loop interchange pass in GCC, as described by > its comments: > +/* This pass performs loop interchange: for example, the loop nest > + > + for (int j = 0; j < N; j++) > + for (int k

[PATCH GCC]A simple implementation of loop interchange

2017-08-30 Thread Bin Cheng
Hi, This patch implements a simple loop interchange pass in GCC, as described by its comments: +/* This pass performs loop interchange: for example, the loop nest + + for (int j = 0; j < N; j++) + for (int k = 0; k < N; k++) + for (int i = 0; i < N; i++) +c[i][j] = c[i][j] +