Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-09-26 Thread Tom de Vries
On 09/26/2011 12:29 PM, Richard Guenther wrote: > On Sun, 25 Sep 2011, Tom de Vries wrote: > >> On 09/25/2011 10:57 AM, Richard Guenther wrote: >>> On Sat, Sep 24, 2011 at 5:29 PM, Eric Botcazou >>> wrote: > This is an updated version of the patch. I have 2 new patches and an > updated t

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-09-26 Thread Richard Guenther
On Sun, 25 Sep 2011, Tom de Vries wrote: > On 09/25/2011 10:57 AM, Richard Guenther wrote: > > On Sat, Sep 24, 2011 at 5:29 PM, Eric Botcazou > > wrote: > >>> This is an updated version of the patch. I have 2 new patches and an > >>> updated testcase which I will sent out individually. > >>> > >

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-09-26 Thread Eric Botcazou
> I tried to implement the approach you describe above in attached patch. Thanks a lot, this indeed fixes the problem! > Currently testing on x86_64. Please also install the testcase I posted in the other message in conjunction with the fix. Thanks in advance. -- Eric Botcazou

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-09-26 Thread Eric Botcazou
> Ugh, yeah. I suppose PTA assigned a HEAP var as pointed-to object for the > original pointer, even if the transformed stmt > > orig_ptr_1 = &a; > > has the points-to information preserved for orig_ptr_1 further propagation > of &a will make accesses through orig_ptr_1 have different alias > pro

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-09-25 Thread Tom de Vries
On 09/25/2011 10:57 AM, Richard Guenther wrote: > On Sat, Sep 24, 2011 at 5:29 PM, Eric Botcazou wrote: >>> This is an updated version of the patch. I have 2 new patches and an >>> updated testcase which I will sent out individually. >>> >>> Patch set was bootstrapped and reg-tested on x86_64. >>>

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-09-25 Thread Richard Guenther
On Sat, Sep 24, 2011 at 5:29 PM, Eric Botcazou wrote: >> This is an updated version of the patch. I have 2 new patches and an >> updated testcase which I will sent out individually. >> >> Patch set was bootstrapped and reg-tested on x86_64. >> >> Ok for trunk? >> >> Thanks, >> - Tom >> >> 2011-07-

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-09-25 Thread Eric Botcazou
> How about attached (untested) patch implementing a conservative, but > runtime-efficient approach? This doesn't work. My understanding is that you need to recompute far more than that, in particular the points-to information for _all_ the calls in the function. I don't know enough of the mac

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-09-24 Thread Tom de Vries
On 09/24/2011 05:29 PM, Eric Botcazou wrote: >> This is an updated version of the patch. I have 2 new patches and an >> updated testcase which I will sent out individually. >> >> Patch set was bootstrapped and reg-tested on x86_64. >> >> Ok for trunk? >> >> Thanks, >> - Tom >> >> 2011-07-30 Tom de

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-09-24 Thread Eric Botcazou
> This is an updated version of the patch. I have 2 new patches and an > updated testcase which I will sent out individually. > > Patch set was bootstrapped and reg-tested on x86_64. > > Ok for trunk? > > Thanks, > - Tom > > 2011-07-30 Tom de Vries > > PR middle-end/43513 > * Makefil

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-08-31 Thread H.J. Lu
On Sat, Jul 30, 2011 at 12:21 AM, Tom de Vries wrote: > > This is an updated version of the patch. I have 2 new patches and an updated > testcase which I will sent out individually. > > Patch set was bootstrapped and reg-tested on x86_64. > > Ok for trunk? > > Thanks, > - Tom > > 2011-07-30  Tom d

Re: [PING][PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-08-30 Thread Richard Guenther
On Wed, Aug 24, 2011 at 10:47 AM, Tom de Vries wrote: > Hi Richard, > > On 07/30/2011 09:21 AM, Tom de Vries wrote: >> This is an updated version of the patch. I have 2 new patches and an updated >> testcase which I will sent out individually. >> >> Patch set was bootstrapped and reg-tested on x86

[PING][PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-08-24 Thread Tom de Vries
Hi Richard, On 07/30/2011 09:21 AM, Tom de Vries wrote: > This is an updated version of the patch. I have 2 new patches and an updated > testcase which I will sent out individually. > > Patch set was bootstrapped and reg-tested on x86_64. > > Ok for trunk? > You already approved the the 2 new

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-08-07 Thread Tom de Vries
On 07/30/2011 09:21 AM, Tom de Vries wrote: > Hi, > > On 07/28/2011 08:20 PM, Tom de Vries wrote: >> On 07/28/2011 06:25 PM, Richard Guenther wrote: >>> On Thu, 28 Jul 2011, Tom de Vries wrote: >>> On 07/28/2011 12:22 PM, Richard Guenther wrote: > On Wed, 27 Jul 2011, Tom de Vries wrote:

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-30 Thread Richard Guenther
On Sat, Jul 30, 2011 at 9:24 AM, Tom de Vries wrote: > On 07/30/2011 10:21 AM, Tom de Vries wrote: >> Hi, >> >> On 07/28/2011 08:20 PM, Tom de Vries wrote: >>> On 07/28/2011 06:25 PM, Richard Guenther wrote: On Thu, 28 Jul 2011, Tom de Vries wrote: > On 07/28/2011 12:22 PM, Richard G

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-30 Thread Richard Guenther
On Sat, Jul 30, 2011 at 9:34 AM, Tom de Vries wrote: > On 07/30/2011 10:21 AM, Tom de Vries wrote: >> Hi, >> >> On 07/28/2011 08:20 PM, Tom de Vries wrote: >>> On 07/28/2011 06:25 PM, Richard Guenther wrote: On Thu, 28 Jul 2011, Tom de Vries wrote: > On 07/28/2011 12:22 PM, Richard G

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-30 Thread Tom de Vries
On 07/30/2011 10:21 AM, Tom de Vries wrote: > Hi, > > On 07/28/2011 08:20 PM, Tom de Vries wrote: >> On 07/28/2011 06:25 PM, Richard Guenther wrote: >>> On Thu, 28 Jul 2011, Tom de Vries wrote: >>> On 07/28/2011 12:22 PM, Richard Guenther wrote: > On Wed, 27 Jul 2011, Tom de Vries wrote:

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-30 Thread Tom de Vries
On 07/30/2011 10:21 AM, Tom de Vries wrote: > Hi, > > On 07/28/2011 08:20 PM, Tom de Vries wrote: >> On 07/28/2011 06:25 PM, Richard Guenther wrote: >>> On Thu, 28 Jul 2011, Tom de Vries wrote: >>> On 07/28/2011 12:22 PM, Richard Guenther wrote: > On Wed, 27 Jul 2011, Tom de Vries wrote:

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-30 Thread Tom de Vries
Hi, On 07/28/2011 08:20 PM, Tom de Vries wrote: > On 07/28/2011 06:25 PM, Richard Guenther wrote: >> On Thu, 28 Jul 2011, Tom de Vries wrote: >> >>> On 07/28/2011 12:22 PM, Richard Guenther wrote: On Wed, 27 Jul 2011, Tom de Vries wrote: > On 07/27/2011 05:27 PM, Richard Guenther wro

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-29 Thread Tom de Vries
On 07/28/2011 12:22 PM, Richard Guenther wrote: > On Wed, 27 Jul 2011, Tom de Vries wrote: > >> On 07/27/2011 05:27 PM, Richard Guenther wrote: >>> On Wed, 27 Jul 2011, Tom de Vries wrote: >>> On 07/27/2011 02:12 PM, Richard Guenther wrote: > On Wed, 27 Jul 2011, Tom de Vries wrote: >

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-28 Thread Richard Guenther
On Thu, Jul 28, 2011 at 7:20 PM, Tom de Vries wrote: > On 07/28/2011 06:25 PM, Richard Guenther wrote: >> On Thu, 28 Jul 2011, Tom de Vries wrote: >> >>> On 07/28/2011 12:22 PM, Richard Guenther wrote: On Wed, 27 Jul 2011, Tom de Vries wrote: > On 07/27/2011 05:27 PM, Richard Guenthe

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-28 Thread Tom de Vries
On 07/28/2011 06:25 PM, Richard Guenther wrote: > On Thu, 28 Jul 2011, Tom de Vries wrote: > >> On 07/28/2011 12:22 PM, Richard Guenther wrote: >>> On Wed, 27 Jul 2011, Tom de Vries wrote: >>> On 07/27/2011 05:27 PM, Richard Guenther wrote: > On Wed, 27 Jul 2011, Tom de Vries wrote: >

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-28 Thread Richard Guenther
On Thu, 28 Jul 2011, Tom de Vries wrote: > On 07/28/2011 12:22 PM, Richard Guenther wrote: > > On Wed, 27 Jul 2011, Tom de Vries wrote: > > > >> On 07/27/2011 05:27 PM, Richard Guenther wrote: > >>> On Wed, 27 Jul 2011, Tom de Vries wrote: > >>> > On 07/27/2011 02:12 PM, Richard Guenther wro

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-28 Thread Richard Guenther
On Wed, 27 Jul 2011, Tom de Vries wrote: > On 07/27/2011 05:27 PM, Richard Guenther wrote: > > On Wed, 27 Jul 2011, Tom de Vries wrote: > > > >> On 07/27/2011 02:12 PM, Richard Guenther wrote: > >>> On Wed, 27 Jul 2011, Tom de Vries wrote: > >>> > On 07/27/2011 01:50 PM, Tom de Vries wrote:

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-28 Thread Richard Guenther
On Wed, 27 Jul 2011, Michael Matz wrote: > Hi, > > On Wed, 27 Jul 2011, Richard Guenther wrote: > > > > > I don't think it is safe to try to get at the VLA type the way you do. > > > > > > I don't understand in what way it's not safe. Do you mean I don't manage > > > to find > > > the type alw

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-27 Thread Tom de Vries
On 07/27/2011 05:27 PM, Richard Guenther wrote: > On Wed, 27 Jul 2011, Tom de Vries wrote: > >> On 07/27/2011 02:12 PM, Richard Guenther wrote: >>> On Wed, 27 Jul 2011, Tom de Vries wrote: >>> On 07/27/2011 01:50 PM, Tom de Vries wrote: > Hi Richard, > > I have a patch set for bug

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-27 Thread Michael Matz
Hi, On Wed, 27 Jul 2011, Richard Guenther wrote: > > > I don't think it is safe to try to get at the VLA type the way you do. > > > > I don't understand in what way it's not safe. Do you mean I don't manage to > > find > > the type always, or that I find the wrong type, or something else? > >

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-27 Thread Richard Guenther
On Wed, 27 Jul 2011, Tom de Vries wrote: > On 07/27/2011 02:12 PM, Richard Guenther wrote: > > On Wed, 27 Jul 2011, Tom de Vries wrote: > > > >> On 07/27/2011 01:50 PM, Tom de Vries wrote: > >>> Hi Richard, > >>> > >>> I have a patch set for bug 43513 - The stack pointer is adjusted twice. > >>>

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-27 Thread Tom de Vries
On 07/27/2011 02:12 PM, Richard Guenther wrote: > On Wed, 27 Jul 2011, Tom de Vries wrote: > >> On 07/27/2011 01:50 PM, Tom de Vries wrote: >>> Hi Richard, >>> >>> I have a patch set for bug 43513 - The stack pointer is adjusted twice. >>> >>> 01_pr43513.3.patch >>> 02_pr43513.3.test.patch >>> 03_

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-27 Thread Richard Guenther
On Wed, 27 Jul 2011, Tom de Vries wrote: > On 07/27/2011 01:50 PM, Tom de Vries wrote: > > Hi Richard, > > > > I have a patch set for bug 43513 - The stack pointer is adjusted twice. > > > > 01_pr43513.3.patch > > 02_pr43513.3.test.patch > > 03_pr43513.3.mudflap.patch > > > > The patch set has

[PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-27 Thread Tom de Vries
On 07/27/2011 01:50 PM, Tom de Vries wrote: > Hi Richard, > > I have a patch set for bug 43513 - The stack pointer is adjusted twice. > > 01_pr43513.3.patch > 02_pr43513.3.test.patch > 03_pr43513.3.mudflap.patch > > The patch set has been bootstrapped and reg-tested on x86_64. > > I will sent o