Re: [PATCH PR95700] Use nullptr instead of NULL as a sentinel value

2020-06-29 Thread Richard Biener via Gcc-patches
On Sat, Jun 27, 2020 at 2:06 PM Richard Sandiford wrote: > > Ilya Leoshkevich via Gcc-patches writes: > > Bootstrapped and regtested on x86_64-redhat-linux, ppc64le-redhat-linux > > and s390x-redhat-linux. > > Agree we should do this FWIW, but as a belt-and-braces fix, would it > make sense to

Re: [PATCH PR95700] Use nullptr instead of NULL as a sentinel value

2020-06-27 Thread Richard Sandiford
Ilya Leoshkevich via Gcc-patches writes: > Bootstrapped and regtested on x86_64-redhat-linux, ppc64le-redhat-linux > and s390x-redhat-linux. Agree we should do this FWIW, but as a belt-and-braces fix, would it make sense to define NULL to nullptr in system.h for all hosts? Currently we have:

Re: [PATCH PR95700] Use nullptr instead of NULL as a sentinel value

2020-06-25 Thread Jonathan Wakely via Gcc-patches
On 25/06/20 13:29 +0200, Ilya Leoshkevich wrote: On Wed, 2020-06-24 at 16:16 +0200, Richard Biener wrote: On Wed, Jun 24, 2020 at 4:14 PM Jonathan Wakely via Gcc-patches wrote: > On 24/06/20 12:31 +0200, Ilya Leoshkevich wrote: > > Bootstrapped and regtested on x86_64-redhat-linux, ppc64le- >

Re: [PATCH PR95700] Use nullptr instead of NULL as a sentinel value

2020-06-25 Thread Ilya Leoshkevich via Gcc-patches
On Wed, 2020-06-24 at 16:16 +0200, Richard Biener wrote: > On Wed, Jun 24, 2020 at 4:14 PM Jonathan Wakely via Gcc-patches > wrote: > > On 24/06/20 12:31 +0200, Ilya Leoshkevich wrote: > > > Bootstrapped and regtested on x86_64-redhat-linux, ppc64le- > > > redhat-linux > > > and

Re: [PATCH PR95700] Use nullptr instead of NULL as a sentinel value

2020-06-24 Thread Richard Biener via Gcc-patches
On Wed, Jun 24, 2020 at 4:14 PM Jonathan Wakely via Gcc-patches wrote: > > On 24/06/20 12:31 +0200, Ilya Leoshkevich wrote: > >Bootstrapped and regtested on x86_64-redhat-linux, ppc64le-redhat-linux > >and s390x-redhat-linux. > > > >Ok for master? > > > >--- > > > >Bootstrap with musl libc fails

Re: [PATCH PR95700] Use nullptr instead of NULL as a sentinel value

2020-06-24 Thread Jonathan Wakely via Gcc-patches
On 24/06/20 12:31 +0200, Ilya Leoshkevich wrote: Bootstrapped and regtested on x86_64-redhat-linux, ppc64le-redhat-linux and s390x-redhat-linux. Ok for master? --- Bootstrap with musl libc fails with numerous "missing sentinel in function call" errors. This is because musl defines NULL as 0L

[PATCH PR95700] Use nullptr instead of NULL as a sentinel value

2020-06-24 Thread Ilya Leoshkevich via Gcc-patches
Bootstrapped and regtested on x86_64-redhat-linux, ppc64le-redhat-linux and s390x-redhat-linux. Ok for master? --- Bootstrap with musl libc fails with numerous "missing sentinel in function call" errors. This is because musl defines NULL as 0L for C++, but gcc requires sentinel value to be a