Re: [PATCH driver/diagnostics] init color earlier, add color to driver

2014-12-04 Thread Manuel López-Ibáñez
On 3 December 2014 at 08:59, Jakub Jelinek ja...@redhat.com wrote: I think using a default argument for this is fine, though of course you need to declare the default argument in the header containing the prototype, not in the function definition. Ok with that change. This is what I have

Re: [PATCH driver/diagnostics] init color earlier, add color to driver

2014-12-02 Thread Joseph Myers
On Tue, 2 Dec 2014, Manuel López-Ibáñez wrote: 2014-12-02 Manuel López-Ibáñez m...@gcc.gnu.org * diagnostic.c (diagnostic_color_init): New. * diagnostic.h: Declare. * gcc.c (driver::global_initializations): Use it. (driver_handle_option): Handle -fdiagnostics-color_.

Re: [PATCH driver/diagnostics] init color earlier, add color to driver

2014-12-02 Thread Jakub Jelinek
On Tue, Dec 02, 2014 at 12:40:12AM +0100, Manuel López-Ibáñez wrote: 2014-12-02 Manuel López-Ibáñez m...@gcc.gnu.org * diagnostic.c (diagnostic_color_init): New. * diagnostic.h: Declare. * gcc.c (driver::global_initializations): Use it. (driver_handle_option): Handle

[PATCH driver/diagnostics] init color earlier, add color to driver

2014-12-01 Thread Manuel López-Ibáñez
The initialization of color diagnostics occurs too late to affect, for example, the unrecognized command line option error. Unfortunately, in the compiler proper we cannot initialize colors just after diagnostic_initialize() because the FEs replace the pretty-printer with their own by destroying