Re: [PATCH i386 AVX512] [56/n] Add plus/minus/abs/neg/andnot insn patterns.

2014-10-20 Thread Jakub Jelinek
On Tue, Oct 14, 2014 at 11:18:28AM +0400, Kirill Yukhin wrote: * config/i386/sse.md (define_mode_iterator VI_AVX2): Extend to support AVX-512BW. (define_mode_iterator VI124_AVX2_48_AVX512F): Remove. (define_expand plusminus_insnmode3): Remove masking support.

Re: [PATCH i386 AVX512] [56/n] Add plus/minus/abs/neg/andnot insn patterns.

2014-10-20 Thread Kirill Yukhin
Hello, On 20 Oct 14:36, Jakub Jelinek wrote: On Tue, Oct 14, 2014 at 11:18:28AM +0400, Kirill Yukhin wrote: * config/i386/sse.md (define_mode_iterator VI_AVX2): Extend to support AVX-512BW. (define_mode_iterator VI124_AVX2_48_AVX512F): Remove. (define_expand

Re: [PATCH i386 AVX512] [56/n] Add plus/minus/abs/neg/andnot insn patterns.

2014-10-20 Thread Jakub Jelinek
On Mon, Oct 20, 2014 at 05:30:36PM +0400, Kirill Yukhin wrote: Unfortunately this caused PR63600. The problem is that VI_AVX2 mode iterator includes V2DI and for AVX2 also V4DI, but for pre-ssse3 ix86_expand_sse2_abs doesn't handle V2DI (and can't easily, we don't have PSRAQ instruction),

Re: [PATCH i386 AVX512] [56/n] Add plus/minus/abs/neg/andnot insn patterns.

2014-10-20 Thread Uros Bizjak
On Mon, Oct 20, 2014 at 3:41 PM, Jakub Jelinek ja...@redhat.com wrote: On Mon, Oct 20, 2014 at 05:30:36PM +0400, Kirill Yukhin wrote: Unfortunately this caused PR63600. The problem is that VI_AVX2 mode iterator includes V2DI and for AVX2 also V4DI, but for pre-ssse3 ix86_expand_sse2_abs

Re: [PATCH i386 AVX512] [56/n] Add plus/minus/abs/neg/andnot insn patterns.

2014-10-14 Thread Kirill Yukhin
Hello Uroš, It seems like I missed to post uppdated patch. On 25 Sep 20:11, Uros Bizjak wrote: I'd rather go with the second approach, it is less confusing from the maintainer POV. All other patterns with masking use some consistent template, so I'd suggest using the same approach for

Re: [PATCH i386 AVX512] [56/n] Add plus/minus/abs/neg/andnot insn patterns.

2014-10-14 Thread Uros Bizjak
On Tue, Oct 14, 2014 at 9:18 AM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hello Uroš, It seems like I missed to post uppdated patch. On 25 Sep 20:11, Uros Bizjak wrote: I'd rather go with the second approach, it is less confusing from the maintainer POV. All other patterns with masking

[PATCH i386 AVX512] [56/n] Add plus/minus/abs/neg/andnot insn patterns.

2014-09-25 Thread Kirill Yukhin
Hello, Patch in the bottom extends plus/minus/abs/andnot patterns to support AVX-512. I've used questionable hack in the patterns. Instead of writing dozen similar patterns with masking I've simply substed them, prohibiting non-mask variant in the pattern condition. E.g.: (define_expand

Re: [PATCH i386 AVX512] [56/n] Add plus/minus/abs/neg/andnot insn patterns.

2014-09-25 Thread Uros Bizjak
On Thu, Sep 25, 2014 at 4:12 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hello, Patch in the bottom extends plus/minus/abs/andnot patterns to support AVX-512. I've used questionable hack in the patterns. Instead of writing dozen similar patterns with masking I've simply substed them,