Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-06-13 Thread kamlesh kumar via Gcc-patches
Thank you all for the suggestions. This is first patch where I have just defined a struct libcall_arg_t which contains three member rtx, machine_mode and a boolean unsigned_p and will be used in passing args in emit_library_[call/value] functions. Once this patch is approved then i will create

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-06-11 Thread Segher Boessenkool
On Tue, Jun 09, 2020 at 02:29:13PM -0600, Jeff Law wrote: > On Sun, 2020-05-24 at 11:22 -0500, Segher Boessenkool wrote: > > OTOH, you don't need to name Tuple at all... It should not *have* a > > constructor, since you declared it as class... But you can just use > > std::tuple here? > > > > >

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-06-09 Thread Jeff Law via Gcc-patches
On Sun, 2020-05-24 at 11:22 -0500, Segher Boessenkool wrote: > Hi! > > On Sun, May 24, 2020 at 07:03:13PM +0530, Kamlesh Kumar wrote: > > In this patch series trying to address same by creating a struct Tuple > > which bundles existing rtx and machine_mode and added one more > > bool member which

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-05-26 Thread Richard Sandiford
Thanks for working on this. Kamlesh Kumar via Gcc-patches writes: > Here is a discussion we did some time ago regarding the defect. > https://gcc.gnu.org/pipermail/gcc/2019-January/227834.html > please see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88877 for testcase > behavior. > > We

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-05-25 Thread Iain Sandoe via Gcc-patches
Jakub Jelinek via Gcc-patches wrote: On Mon, May 25, 2020 at 06:37:57PM +0200, Richard Biener wrote: I thought of using std::tuple but it requires c++11 support. I am not sure we always build gcc with c++11? https://gcc.gnu.org/install/prerequisites.html We do for GCC 11 :-) Since we pay

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-05-25 Thread Jakub Jelinek via Gcc-patches
On Mon, May 25, 2020 at 06:37:57PM +0200, Richard Biener wrote: > >> I thought of using std::tuple but it requires c++11 support. > >> I am not sure we always build gcc with c++11? > > > >https://gcc.gnu.org/install/prerequisites.html > > > >We do for GCC 11 :-) Since we pay the price for

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-05-25 Thread Richard Biener
On May 25, 2020 6:31:29 PM GMT+02:00, Segher Boessenkool wrote: >On Mon, May 25, 2020 at 12:46:02PM +0530, kamlesh kumar wrote: >> > OTOH, you don't need to name Tuple at all... It should not *have* >a >> > constructor, since you declared it as class... But you can just >use >> > std::tuple

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-05-25 Thread Segher Boessenkool
On Mon, May 25, 2020 at 12:46:02PM +0530, kamlesh kumar wrote: > > OTOH, you don't need to name Tuple at all... It should not *have* a > > constructor, since you declared it as class... But you can just use > > std::tuple here? > > I thought of using std::tuple but it requires c++11 support. >

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-05-25 Thread kamlesh kumar via Gcc-patches
> OTOH, you don't need to name Tuple at all... It should not *have* a > constructor, since you declared it as class... But you can just use > std::tuple here? I thought of using std::tuple but it requires c++11 support. I am not sure we always build gcc with c++11? > > >

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-05-24 Thread Segher Boessenkool
Hi! On Sun, May 24, 2020 at 07:03:13PM +0530, Kamlesh Kumar wrote: > In this patch series trying to address same by creating a struct Tuple > which bundles existing rtx and machine_mode and added one more > bool member which store unsigned_p which by default is false. The idea is good. However,

[PATCH v1 1/2][PPC64] [PR88877]

2020-05-24 Thread Kamlesh Kumar via Gcc-patches
Here is a discussion we did some time ago regarding the defect. https://gcc.gnu.org/pipermail/gcc/2019-January/227834.html please see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88877 for testcase behavior. We incorporating below Jakub's suggestion in this patch series. Jakub wrote: "" Yeah,