Re: [PATCH v1.1] tree-optimization/105736: Don't let error_mark_node escape for ADDR_EXPR

2022-06-21 Thread Siddhesh Poyarekar
On 20/06/2022 15:20, Jakub Jelinek wrote: On Tue, Jun 14, 2022 at 09:01:54PM +0530, Siddhesh Poyarekar wrote: The addr_expr computation does not check for error_mark_node before returning the size expression. This used to work in the constant case because the conversion to uhwi would end up

Re: [PATCH v1.1] tree-optimization/105736: Don't let error_mark_node escape for ADDR_EXPR

2022-06-20 Thread Jakub Jelinek via Gcc-patches
On Tue, Jun 14, 2022 at 09:01:54PM +0530, Siddhesh Poyarekar wrote: > The addr_expr computation does not check for error_mark_node before > returning the size expression. This used to work in the constant case > because the conversion to uhwi would end up causing it to return > size_unknown, but

[ping][PATCH v1.1] tree-optimization/105736: Don't let error_mark_node escape for ADDR_EXPR

2022-06-19 Thread Siddhesh Poyarekar
Hello, ping! On 14/06/2022 21:01, Siddhesh Poyarekar wrote: The addr_expr computation does not check for error_mark_node before returning the size expression. This used to work in the constant case because the conversion to uhwi would end up causing it to return size_unknown, but that won't

[PATCH v1.1] tree-optimization/105736: Don't let error_mark_node escape for ADDR_EXPR

2022-06-14 Thread Siddhesh Poyarekar
The addr_expr computation does not check for error_mark_node before returning the size expression. This used to work in the constant case because the conversion to uhwi would end up causing it to return size_unknown, but that won't work for the dynamic case. Modify the control flow to explicitly