Re: [PATCH v2] New C++ warning option '-Waccess-specifiers'

2017-07-26 Thread Eric Gallager
On 7/24/17, Franz Sirl wrote: > Am 2017-07-24 um 00:19 schrieb Volker Reichelt: >> On 23 Jul, Eric Gallager wrote: >>> On 7/23/17, Volker Reichelt wrote: Hi again, here is an updated patch for a new warning about redundant access-specifiers. It takes Dave's various comments in

Re: [PATCH v2] New C++ warning option '-Waccess-specifiers'

2017-07-25 Thread Volker Reichelt
On 25 Jul, Marek Polacek wrote: > On Sun, Jul 23, 2017 at 11:22:14PM +0200, Volker Reichelt wrote: > [...] > > Not sure if the warning is too useful, but in any case... > >> + /* Emit warning. */ >> + gcc_rich_location richloc (token->location); >> + richloc.add_fixit_remove (); >> + if (col

Re: [PATCH v2] New C++ warning option '-Waccess-specifiers'

2017-07-25 Thread Marek Polacek
On Sun, Jul 23, 2017 at 11:22:14PM +0200, Volker Reichelt wrote: [...] Not sure if the warning is too useful, but in any case... > + /* Emit warning. */ > + gcc_rich_location richloc (token->location); > + richloc.add_fixit_remove (); > + if (colon_token->type == CPP_COLON) > +richloc.ad

Re: [PATCH v2] New C++ warning option '-Waccess-specifiers'

2017-07-24 Thread Franz Sirl
Am 2017-07-24 um 00:19 schrieb Volker Reichelt: On 23 Jul, Eric Gallager wrote: On 7/23/17, Volker Reichelt wrote: Hi again, here is an updated patch for a new warning about redundant access-specifiers. It takes Dave's various comments into account. The main changes w.r.t. to the previous ve

Re: [PATCH v2] New C++ warning option '-Waccess-specifiers'

2017-07-23 Thread Volker Reichelt
On 23 Jul, Eric Gallager wrote: > On 7/23/17, Volker Reichelt wrote: >> Hi again, >> >> here is an updated patch for a new warning about redundant >> access-specifiers. It takes Dave's various comments into account. >> >> The main changes w.r.t. to the previous versions are: >> >> * The warning is

Re: [PATCH v2] New C++ warning option '-Waccess-specifiers'

2017-07-23 Thread Eric Gallager
On 7/23/17, Volker Reichelt wrote: > Hi again, > > here is an updated patch for a new warning about redundant > access-specifiers. It takes Dave's various comments into account. > > The main changes w.r.t. to the previous versions are: > > * The warning is now a two-level warning with a slightly s

[PATCH v2] New C++ warning option '-Waccess-specifiers'

2017-07-23 Thread Volker Reichelt
Hi again, here is an updated patch for a new warning about redundant access-specifiers. It takes Dave's various comments into account. The main changes w.r.t. to the previous versions are: * The warning is now a two-level warning with a slightly shorter name: -Waccess-specifiers=1, -Waccess-sp