Re: [PATCH v2] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)

2021-03-09 Thread Jeff Law via Gcc-patches
On 3/8/21 3:21 PM, Eric Botcazou wrote: >> This one worked. Is that what you had in mind? >> >> * raise-gcc.c: On Cygwin include mingw32.h to prevent >> windows.h from including x86intrin.h or emmintrin.h. > Yep, exactly, thanks, you may put it on whichever branch you need. I've

Re: [PATCH v2] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)

2021-03-08 Thread Eric Botcazou
> This one worked. Is that what you had in mind? > > * raise-gcc.c: On Cygwin include mingw32.h to prevent > windows.h from including x86intrin.h or emmintrin.h. Yep, exactly, thanks, you may put it on whichever branch you need. -- Eric Botcazou

Re: [PATCH v2] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)

2021-03-08 Thread Mikael Pettersson via Gcc-patches
On Mon, Mar 8, 2021 at 12:07 PM Eric Botcazou wrote: > > > I wonder why we include from this file at all, > > and why it is not included from {t,}system.h instead which > > is where system header specific fixups should be made > > (and this one could be avoided because system headers > > are

Re: [PATCH v2] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)

2021-03-08 Thread Eric Botcazou
> I wonder why we include from this file at all, > and why it is not included from {t,}system.h instead which > is where system header specific fixups should be made > (and this one could be avoided because system headers > are included _before_ poisoning anything). is the Mother of All Things

Re: [PATCH v2] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)

2021-03-08 Thread Richard Biener via Gcc-patches
On Sun, Jan 10, 2021 at 2:05 PM Mikael Pettersson via Gcc-patches wrote: > > On Sun, Jan 10, 2021 at 11:57 AM Arnaud Charlet wrote: > > > > > This fixes a compilation error preventing bootstrap with Ada on > > > x86_64-pc-cygwin. See PR bootstrap/94918 for details. > > > > > > Compared to the

Re: [PATCH v2] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)

2021-03-07 Thread Arnaud Charlet
> > > > This fixes a compilation error preventing bootstrap with Ada on > > > > x86_64-pc-cygwin. See PR bootstrap/94918 for details. > > > > > > > > Compared to the initial patch sent in May 2020, this v2 patch places > > > > the fix in Ada's raise-gcc.c instead of the shared unwind-generic.h, >

Re: [PATCH v2] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)

2021-03-07 Thread Mikael Pettersson via Gcc-patches
On Sun, Jan 10, 2021 at 2:04 PM Mikael Pettersson wrote: > > On Sun, Jan 10, 2021 at 11:57 AM Arnaud Charlet wrote: > > > > > This fixes a compilation error preventing bootstrap with Ada on > > > x86_64-pc-cygwin. See PR bootstrap/94918 for details. > > > > > > Compared to the initial patch sent

Re: [PATCH v2] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)

2021-01-10 Thread Mikael Pettersson via Gcc-patches
On Sun, Jan 10, 2021 at 11:57 AM Arnaud Charlet wrote: > > > This fixes a compilation error preventing bootstrap with Ada on > > x86_64-pc-cygwin. See PR bootstrap/94918 for details. > > > > Compared to the initial patch sent in May 2020, this v2 patch places > > the fix in Ada's raise-gcc.c

Re: [PATCH v2] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)

2021-01-10 Thread Arnaud Charlet
> This fixes a compilation error preventing bootstrap with Ada on > x86_64-pc-cygwin. See PR bootstrap/94918 for details. > > Compared to the initial patch sent in May 2020, this v2 patch places > the fix in Ada's raise-gcc.c instead of the shared unwind-generic.h, > which should hopefully

[PATCH v2] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)

2021-01-10 Thread Mikael Pettersson via Gcc-patches
This fixes a compilation error preventing bootstrap with Ada on x86_64-pc-cygwin. See PR bootstrap/94918 for details. Compared to the initial patch sent in May 2020, this v2 patch places the fix in Ada's raise-gcc.c instead of the shared unwind-generic.h, which should hopefully simplify getting