Re: [PATCH v2] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

On 11/25/14 7:56, Joseph Myers wrote: On Sun, 23 Nov 2014, Chen Gang wrote: + gcc_assert (wi::fits_to_tree_p(value, integer_type_node)); Watch formatting: space before '(' in the wi::fits_to_tree_p call. Applies elsewhere in this patch as well. OK, thanks, I shall notice next. When

Re: [PATCH v2] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

On Sun, 23 Nov 2014, Chen Gang wrote: + gcc_assert (wi::fits_to_tree_p(value, integer_type_node)); Watch formatting: space before '(' in the wi::fits_to_tree_p call. Applies elsewhere in this patch as well. When making such an interface change, (a) you should update the comment on

Re: [PATCH v2] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

OK, thank you for your work, I shall send patch v3 for it. Send from Lenovo A788t. Joseph Myers jos...@codesourcery.com wrote: On Sun, 23 Nov 2014, Chen Gang wrote: + gcc_assert (wi::fits_to_tree_p(value, integer_type_node)); Watch formatting: space before '(' in the wi::fits_to_tree_p

[PATCH v2] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

The original length 18 is not enough for HOST_WIDE_INT printing, need use 20 instead of. Also need additional bytes for printing related prefix and suffix, and define the related macro in hwint.h. It passes testsuite under fedora 20 x86_64-unknown-linux-gnu. 2014-11-23 Chen Gang