Re: [PATCH v2 01/31] PR target/58901: reload: Handle SUBREG of MEM with a mode-dependent address

2020-11-29 Thread Jeff Law via Gcc-patches
On 11/27/20 12:22 PM, Maciej W. Rozycki wrote: > On Fri, 27 Nov 2020, Ulrich Weigand wrote: > >>> NB I find the reindentation resulting in `push_reload' awful, just as I >>> do either version of the massive logical expression involved. Perhaps we >>> could factor these out into `static

Re: [PATCH v2 01/31] PR target/58901: reload: Handle SUBREG of MEM with a mode-dependent address

2020-11-27 Thread Maciej W. Rozycki
On Fri, 27 Nov 2020, Maciej W. Rozycki wrote: > > That said, if it fixes the test suite errors you're seeing, it would > > probably be OK to go with just this minimal change -- unless we can > > just move to LRA as mentioned above. > > I've looked through the test results and indeed these

Re: [PATCH v2 01/31] PR target/58901: reload: Handle SUBREG of MEM with a mode-dependent address

2020-11-27 Thread Maciej W. Rozycki
On Fri, 27 Nov 2020, Ulrich Weigand wrote: > > NB I find the reindentation resulting in `push_reload' awful, just as I > > do either version of the massive logical expression involved. Perhaps we > > could factor these out into `static inline' functions sometime, and then > > have them split

Re: [PATCH v2 01/31] PR target/58901: reload: Handle SUBREG of MEM with a mode-dependent address

2020-11-27 Thread Ulrich Weigand via Gcc-patches
On Tue, Nov 24, 2020 at 06:19:41AM +, Maciej W. Rozycki wrote: > NB I find the reindentation resulting in `push_reload' awful, just as I > do either version of the massive logical expression involved. Perhaps we > could factor these out into `static inline' functions sometime, and then

Re: [PATCH v2 01/31] PR target/58901: reload: Handle SUBREG of MEM with a mode-dependent address

2020-11-26 Thread Maciej W. Rozycki
On Thu, 26 Nov 2020, Maciej W. Rozycki wrote: > > > PR target/58901 > > > * reload.c (push_reload): Also reload the inner expression of a > > > SUBREG for pseudos associated with a mode-dependent memory > > > reference. > > > (find_reloads): Force a reload likewise. > > > > Thanks for

Re: [PATCH v2 01/31] PR target/58901: reload: Handle SUBREG of MEM with a mode-dependent address

2020-11-26 Thread Maciej W. Rozycki
On Tue, 24 Nov 2020, Eric Botcazou wrote: > > First posted at: . > > > > 2020-11-24 Matt Thomas > > Maciej W. Rozycki > > > > gcc/ > > PR target/58901 > > * reload.c (push_reload): Also reload the inner expression of a >

Re: [PATCH v2 01/31] PR target/58901: reload: Handle SUBREG of MEM with a mode-dependent address

2020-11-24 Thread Eric Botcazou
> First posted at: . > > 2020-11-24 Matt Thomas > Maciej W. Rozycki > > gcc/ > PR target/58901 > * reload.c (push_reload): Also reload the inner expression of a > SUBREG for pseudos associated with a

[PATCH v2 01/31] PR target/58901: reload: Handle SUBREG of MEM with a mode-dependent address

2020-11-23 Thread Maciej W. Rozycki
From: Matt Thomas Fix an ICE with the handling of RTL expressions like: (subreg:QI (mem/c:SI (plus:SI (plus:SI (mult:SI (reg/v:SI 0 %r0 [orig:67 i ] [67]) (const_int 4 [0x4])) (reg/v/f:SI 7 %r7 [orig:59 doacross ] [59])) (const_int 40 [0x28])) [1