Re: [PATCH v2 4/4] xtensa: Improve constant synthesis for both integer and floating-point

2022-06-11 Thread Max Filippov via Gcc-patches
On Sat, Jun 11, 2022 at 1:31 AM Takayuki 'January June' Suwa wrote: > > this change results in a bunch of ICEs in the tests like this: > > during RTL pass: split2 > > gcc/gcc/testsuite/gcc.c-torture/compile/20120727-1.c: In function 'f': > >

Re: [PATCH v2 4/4] xtensa: Improve constant synthesis for both integer and floating-point

2022-06-11 Thread Max Filippov via Gcc-patches
On Sat, Jun 11, 2022 at 1:31 AM Takayuki 'January June' Suwa wrote: > > this change results in a bunch of ICEs in the tests like this: > > during RTL pass: split2 > > gcc/gcc/testsuite/gcc.c-torture/compile/20120727-1.c: In function 'f': > >

Re: [PATCH v2 4/4] xtensa: Improve constant synthesis for both integer and floating-point

2022-06-11 Thread Takayuki 'January June' Suwa via Gcc-patches
On 2022/06/11 16:58, Max Filippov wrote: Hi Suwa-san, hi! this change results in a bunch of ICEs in the tests like this: during RTL pass: split2 gcc/gcc/testsuite/gcc.c-torture/compile/20120727-1.c: In function 'f': gcc/gcc/testsuite/gcc.c-torture/compile/20120727-1.c:13:1: internal compiler

Re: [PATCH v2 4/4] xtensa: Improve constant synthesis for both integer and floating-point

2022-06-11 Thread Max Filippov via Gcc-patches
Hi Suwa-san, On Fri, Jun 10, 2022 at 8:28 AM Takayuki 'January June' Suwa wrote: > > This patch revises the previous implementation of constant synthesis. > > First, changed to use define_split machine description pattern and to run > after reload pass, in order not to interfere some

[PATCH v2 4/4] xtensa: Improve constant synthesis for both integer and floating-point

2022-06-10 Thread Takayuki 'January June' Suwa via Gcc-patches
This patch revises the previous implementation of constant synthesis. First, changed to use define_split machine description pattern and to run after reload pass, in order not to interfere some optimizations such as the loop invariant motion. Second, not only integer but floating-point is