Re: [PING][PATCH v3] Disable reg offset in quad-word store for Falkor

2018-02-19 Thread Wilco Dijkstra
Siddhesh Poyarekar wrote: > On Thursday 15 February 2018 07:50 PM, Wilco Dijkstra wrote: >> So it seems to me using existing cost mechanisms is always preferable, even >> if you >> currently can't differentiate between loads and stores. > > Luis is working on address cost adjustments among other t

Re: [PING][PATCH v3] Disable reg offset in quad-word store for Falkor

2018-02-15 Thread Siddhesh Poyarekar
On Thursday 15 February 2018 07:50 PM, Wilco Dijkstra wrote: > So it seems to me using existing cost mechanisms is always preferable, even > if you > currently can't differentiate between loads and stores. Luis is working on address cost adjustments among other things, so I guess the path of leas

Re: [PING][PATCH v3] Disable reg offset in quad-word store for Falkor

2018-02-15 Thread Wilco Dijkstra
Hi Siddhesh, I still don't like the idea of disabling a whole class of instructions in the md file. It seems much better to adjust the costs here so that you get most of the improvement now, and fine tune it once we can differentiate between loads and stores. Taking your example, adding -funroll

[PING][PATCH v3] Disable reg offset in quad-word store for Falkor

2018-02-15 Thread Siddhesh Poyarekar
Ping! On Friday 09 February 2018 01:02 PM, Siddhesh Poyarekar wrote: > Hi, > > Here's v3 of the patch to disable register offset addressing mode for > stores of 128-bit values on Falkor because they're very costly. > Following Kyrill's suggestion, I compared the codegen for a53 and > found that t

[PATCH v3] Disable reg offset in quad-word store for Falkor

2018-02-08 Thread Siddhesh Poyarekar
Hi, Here's v3 of the patch to disable register offset addressing mode for stores of 128-bit values on Falkor because they're very costly. Following Kyrill's suggestion, I compared the codegen for a53 and found that the codegen was quite different. Jim's original patch is the most minimal compromi