Re: [PATCH v4] Generalize get_most_common_single_value to return k_th value & count

On 7/17/19 1:55 AM, Martin Liška wrote: > On 7/17/19 7:44 AM, luoxhu wrote: >> Hi Martin, >> Thanks for your review, v4 Changes as below: >> 1. Use decrease bubble sort. >> BTW, I have a question about hist->hvalue.counters[2], when will it become >> -1, please? Thanks. Currently, if it is -1,

Re: [PATCH v4] Generalize get_most_common_single_value to return k_th value & count

On 7/17/19 10:44 AM, luoxhu wrote: > Hi Martin, > > On 2019/7/17 15:55, Martin Liška wrote: >> On 7/17/19 7:44 AM, luoxhu wrote: >>> Hi Martin, >>> Thanks for your review, v4 Changes as below: >>>   1. Use decrease bubble sort. >>> BTW, I have a question about hist->hvalue.counters[2], when will

Re: [PATCH v4] Generalize get_most_common_single_value to return k_th value & count

Hi Martin, On 2019/7/17 15:55, Martin Liška wrote: On 7/17/19 7:44 AM, luoxhu wrote: Hi Martin, Thanks for your review, v4 Changes as below: 1. Use decrease bubble sort. BTW, I have a question about hist->hvalue.counters[2], when will it become -1, please? Thanks. Currently, if it is -1,

Re: [PATCH v4] Generalize get_most_common_single_value to return k_th value & count

On 7/17/19 7:44 AM, luoxhu wrote: > Hi Martin, > Thanks for your review, v4 Changes as below: > 1. Use decrease bubble sort. > BTW, I have a question about hist->hvalue.counters[2], when will it become > -1, please? Thanks. Currently, if it is -1, the function will return false. Hi. Thanks

Re: [PATCH v4] Generalize get_most_common_single_value to return k_th value & count

Currently get_most_common_single_value could only return the max hist , add sort after reading from disk, then it return nth value in later use. Rename it to get_nth_most_common_value. Hi Martin, Thanks for your review, v4 Changes as below: 1. Use decrease bubble sort. BTW, I have a question