Re: [PATCH v7] Practical improvement to libgcc complex divide

2021-02-22 Thread Patrick McGehearty via Gcc-patches
I decided to use float_h_prefix instead of modename or mode prefix as Joseph has better insight as to naming expectations when others are working in gcc/c-family/c-cppbuiltin.c. All requested changes made and tested. Patch coming shortly. - patrick On 2/19/2021 5:48 PM, Joseph Myers wrote:

Re: [PATCH v7] Practical improvement to libgcc complex divide

2021-02-19 Thread Joseph Myers
On Fri, 19 Feb 2021, Patrick McGehearty via Gcc-patches wrote: > > Here you're properly computing the mapping from mode to float.h macro > > prefix (though I think "modename" is a confusing name for the variable > > used for float.h macro prefixes; to me, "modename" suggests the names such > > as

Re: [PATCH v7] Practical improvement to libgcc complex divide

2021-02-19 Thread Patrick McGehearty via Gcc-patches
Comments inline On 2/19/2021 3:27 PM, Joseph Myers wrote: On Tue, 2 Feb 2021, Patrick McGehearty via Gcc-patches wrote: if (mode == TYPE_MODE (double_type_node)) - ; /* Empty suffix correct. */ + { + ; /* Empty suffix correct. */ +

Re: [PATCH v7] Practical improvement to libgcc complex divide

2021-02-19 Thread Joseph Myers
On Tue, 2 Feb 2021, Patrick McGehearty via Gcc-patches wrote: > if (mode == TYPE_MODE (double_type_node)) > - ; /* Empty suffix correct. */ > + { > + ; /* Empty suffix correct. */ > + memcpy (modename, "DBL", 4); > + } > else if (mode

Re: [PATCH v7] Practical improvement to libgcc complex divide

2021-02-11 Thread Patrick McGehearty via Gcc-patches
Ping - Submitted Feb 2, 2021 I believe this version fixes all issues raised in previous submissions. - Patrick McGehearty On 2/2/2021 4:25 PM, Patrick McGehearty via Gcc-patches wrote: Changes in this version from Version 6: Updated copyrights for following three files to -2021.

[PATCH v7] Practical improvement to libgcc complex divide

2021-02-02 Thread Patrick McGehearty via Gcc-patches
Changes in this version from Version 6: Updated copyrights for following three files to -2021. gcc/c-family/c-cppbuiltin.c Moved code for setting LIBGCC modename to FUNC_EXT section. Added code to set modename for any additional modes such as FLT128 or

[PATCH v7] Practical improvement to libgcc complex divide

2021-02-02 Thread Patrick McGehearty via Gcc-patches
Changes in this version from Version 6: Updated copyrights for following three files to -2021. gcc/c-family/c-cppbuiltin.c Moved code for setting LIBGCC modename to FUNC_EXT section. Added code to set modename for any additional modes such as FLT128 or