Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 02/25/2016 04:51 PM, Jakub Jelinek wrote: Do you have some short Ada testcase where the DW_OP_call4 referring to DW_TAG_dwarf_procedure is supposed to be emitted? I believe you must be getting there the .Ldebug_info0+0 invalid reference in the DW_OP_call4 operand. Sure! Here’s one: $ gcc

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 02/25/2016 10:48 AM, Jakub Jelinek wrote: The first one just fixes what I mainly care about, the committed patch assumed that DW_TAG_dwarf_procedure is always only created for the Ada variable sized structures or whatever it was meant for, which is not the case, and thus if we emit

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On Thu, Feb 25, 2016 at 11:35:07AM +0100, Pierre-Marie de Rodat wrote: > On 02/25/2016 10:48 AM, Jakub Jelinek wrote: > >Unfortunately, this broke the DW_OP_GNU_implicit_pointer support, on vast > >majority of binaries and libraries gcc now emits invalid DWARF (which both > >gdb and dwz complain

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

> I agree that catching this in scan-assembler test is hard, but guality test > would catch this. It is true that some guality tests (mostly the ones that > test behaviour of optimized code, which differs a lot between different > architectures) have known FAILs (or known XFAILs), because the

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On Thu, Feb 25, 2016 at 11:35:07AM +0100, Pierre-Marie de Rodat wrote: > As I said at the end of a message in another thread > (https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01078.html), I always feel > uncomfortable writing brittle dg-scan testcases, hence the current lack of > testcases for

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 02/25/2016 10:48 AM, Jakub Jelinek wrote: Unfortunately, this broke the DW_OP_GNU_implicit_pointer support, on vast majority of binaries and libraries gcc now emits invalid DWARF (which both gdb and dwz complain about and dwz refuses to optimize because of that). Arg, sorry about this!

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On Wed, Dec 16, 2015 at 09:53:37AM +0100, Pierre-Marie de Rodat wrote: > On 12/11/2015 09:25 PM, Jason Merrill wrote: > >Hmm, can we generate the DWARF procedures during finalize_size_functions > >to avoid the need for preserve_body? > > Good idea, thank you! Here’s the updated patch

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 01/03/2016 12:45 AM, Eric Botcazou wrote: On powerpc64: FAIL: gnat.dg/specs/debug1.ads scan-assembler-times DW_AT_artificial 18 $ grep -c DW_AT_artificial debug1.s 17 Test removed. Thank you both! -- Pierre-Marie de Rodat

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

Eric Botcazou writes: >> I'm also seeing >> +FAIL: gnat.dg/specs/debug1.ads scan-assembler-times DW_AT_artificial 17 >> and from what I can see in gcc-testresults, I'm not alone. > > Minor oversight, adjusted like so: > > * gnat.dg/specs/debug1.ads: Bump final count

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

> On powerpc64: > > FAIL: gnat.dg/specs/debug1.ads scan-assembler-times DW_AT_artificial 18 > > $ grep -c DW_AT_artificial debug1.s > 17 Test removed. -- Eric Botcazou

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 12/18/2015 09:23 PM, Pierre-Marie de Rodat wrote: On 12/18/2015 06:56 PM, Jason Merrill wrote: These broke a lot of tests in the GDB C++ testsuite. Specifically, the commit DWARF: handle variable-length records and variant parts Arg, sad to hear that! I did testing at some point

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 12/21/2015 04:39 PM, Jason Merrill wrote: OK, thanks. Committed. Thank you again! -- Pierre-Marie de Rodat

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

OK, thanks. Jason

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On Fri, Dec 18, 2015 at 12:56:07PM -0500, Jason Merrill wrote: > On 12/17/2015 09:10 AM, Pierre-Marie de Rodat wrote: > >On 12/16/2015 10:30 PM, Jason Merrill wrote: > >>OK with those changes. > > > >All changes done, and all patches pushed. Thank you very much!! > > These broke a lot of tests in

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 12/17/2015 09:10 AM, Pierre-Marie de Rodat wrote: On 12/16/2015 10:30 PM, Jason Merrill wrote: OK with those changes. All changes done, and all patches pushed. Thank you very much!! These broke a lot of tests in the GDB C++ testsuite. Specifically, the commit DWARF: handle

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

> I'm also seeing > +FAIL: gnat.dg/specs/debug1.ads scan-assembler-times DW_AT_artificial 17 > and from what I can see in gcc-testresults, I'm not alone. Minor oversight, adjusted like so: * gnat.dg/specs/debug1.ads: Bump final count to 18. -- Eric Botcazou Index:

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 12/18/2015 06:56 PM, Jason Merrill wrote: These broke a lot of tests in the GDB C++ testsuite. Specifically, the commit DWARF: handle variable-length records and variant parts Arg, sad to hear that! I did testing at some point with the GDB testsuite… I’ll investigate on Monday,

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 12/16/2015 10:30 PM, Jason Merrill wrote: OK with those changes. All changes done, and all patches pushed. Thank you very much!! -- Pierre-Marie de Rodat

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 12/16/2015 03:53 AM, Pierre-Marie de Rodat wrote: + /* Called from finalize_size_functions for functions whose body is needed to + generate complete debug info. For instance, functions used to compute the + size of variable-length structures. */ + void (* function_body) (tree

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 12/11/2015 09:25 PM, Jason Merrill wrote: Hmm, can we generate the DWARF procedures during finalize_size_functions to avoid the need for preserve_body? Good idea, thank you! Here’s the updated patch (bootstrapped and regtested on x86_64-linux, as usual). -- Pierre-Marie de Rodat >From

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 11/26/2015 07:34 AM, Pierre-Marie de Rodat wrote: On 11/25/2015 07:35 PM, Jason Merrill wrote: Actually, even though my patches introduce DWARF procedures for only one case (size functions from stor-layout.c), they don’t necessarily come from code generation (GENERIC): they are just a way

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 11/25/2015 07:35 PM, Jason Merrill wrote: Actually, even though my patches introduce DWARF procedures for only one case (size functions from stor-layout.c), they don’t necessarily come from code generation (GENERIC): they are just a way to factorize common DWARF operations. Thinking more

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 11/24/2015 04:17 AM, Pierre-Marie de Rodat wrote: On 11/23/2015 10:08 PM, Jason Merrill wrote: On 11/23/2015 08:53 AM, Pierre-Marie de Rodat wrote: Do you think the other patches could make it before the branch? (if they could, I will rebase+retest them as quick as possible). Probably,

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 11/23/2015 10:08 PM, Jason Merrill wrote: On 11/23/2015 08:53 AM, Pierre-Marie de Rodat wrote: Do you think the other patches could make it before the branch? (if they could, I will rebase+retest them as quick as possible). Probably, yes. I can't find the DW_AT_static_link patch, though;

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 11/23/2015 08:53 AM, Pierre-Marie de Rodat wrote: Do you think the other patches could make it before the branch? (if they could, I will rebase+retest them as quick as possible). Probably, yes. I can't find the DW_AT_static_link patch, though; it doesn't seem to have been attached to

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

On 10/20/2015 04:13 PM, Pierre-Marie de Rodat wrote: Sorry about the slow review on these patches. In future please feel free to ping me as often as once a week. + /* DWARF operations all work on signed integers. Note that this will no longer be the case in DWARF 5, where stack elements