Re: [PING][PATCH][PR65443] Add transform_to_exit_first_loop_alt

2015-06-08 Thread Tom de Vries
On 09/06/15 00:05, Tom de Vries wrote: On 08/06/15 17:55, Thomas Schwinge wrote: Hi Tom! On Mon, 8 Jun 2015 12:43:01 +0200, Tom de Vries wrote: There are two problems in try_transform_to_exit_first_loop_alt: 1. In case the latch is not a singleton bb, the function should return false rat

Re: [PING][PATCH][PR65443] Add transform_to_exit_first_loop_alt

2015-06-08 Thread Tom de Vries
On 08/06/15 17:55, Thomas Schwinge wrote: Hi Tom! On Mon, 8 Jun 2015 12:43:01 +0200, Tom de Vries wrote: There are two problems in try_transform_to_exit_first_loop_alt: 1. In case the latch is not a singleton bb, the function should return false rather than true. 2. The check for singleto

Re: [PING][PATCH][PR65443] Add transform_to_exit_first_loop_alt

2015-06-08 Thread Thomas Schwinge
Hi Tom! On Mon, 8 Jun 2015 12:43:01 +0200, Tom de Vries wrote: > There are two problems in try_transform_to_exit_first_loop_alt: > 1. In case the latch is not a singleton bb, the function should return > false rather than true. > 2. The check for singleton bb should ignore debug-insns. > > A

Re: [PING][PATCH][PR65443] Add transform_to_exit_first_loop_alt

2015-06-08 Thread Richard Biener
On Mon, 8 Jun 2015, Tom de Vries wrote: > On 04/06/15 10:28, Tom de Vries wrote: > > > I'm ok with the patch and count on you to fix eventual fallout ;) > > > > > > > Great, will do. > > And here is the fallout: > * PR66442 - [6 regression] FAIL: gcc.dg/autopar/pr46885.c (test for > excess er

Re: [PING][PATCH][PR65443] Add transform_to_exit_first_loop_alt

2015-06-08 Thread Tom de Vries
On 04/06/15 10:28, Tom de Vries wrote: I'm ok with the patch and count on you to fix eventual fallout ;) Great, will do. And here is the fallout: * PR66442 - [6 regression] FAIL: gcc.dg/autopar/pr46885.c (test for excess errors) There are two problems in try_transform_to_exit_first_loop_a

Re: [PING][PATCH][PR65443] Add transform_to_exit_first_loop_alt

2015-06-04 Thread Tom de Vries
On 26/05/15 12:39, Richard Biener wrote: On Thu, 14 May 2015, Tom de Vries wrote: On 20-04-15 14:25, Richard Biener wrote: On Wed, 15 Apr 2015, Tom de Vries wrote: On 03-04-15 14:39, Tom de Vries wrote: On 27-03-15 15:10, Tom de Vries wrote: Hi, this patch fixes PR65443, a todo in the par

Re: [PING][PATCH][PR65443] Add transform_to_exit_first_loop_alt

2015-05-26 Thread Richard Biener
On Thu, 14 May 2015, Tom de Vries wrote: > On 20-04-15 14:25, Richard Biener wrote: > > On Wed, 15 Apr 2015, Tom de Vries wrote: > > > > > On 03-04-15 14:39, Tom de Vries wrote: > > > > On 27-03-15 15:10, Tom de Vries wrote: > > > > > Hi, > > > > > > > > > > this patch fixes PR65443, a todo in t

Re: [PING][PATCH][PR65443] Add transform_to_exit_first_loop_alt

2015-05-14 Thread Tom de Vries
On 20-04-15 14:25, Richard Biener wrote: On Wed, 15 Apr 2015, Tom de Vries wrote: On 03-04-15 14:39, Tom de Vries wrote: On 27-03-15 15:10, Tom de Vries wrote: Hi, this patch fixes PR65443, a todo in the parloops pass for function transform_to_exit_first_loop: ... TODO: the common case

Re: [PING][PATCH][PR65443] Add transform_to_exit_first_loop_alt

2015-04-20 Thread Richard Biener
On Wed, 15 Apr 2015, Tom de Vries wrote: > On 03-04-15 14:39, Tom de Vries wrote: > > On 27-03-15 15:10, Tom de Vries wrote: > > > Hi, > > > > > > this patch fixes PR65443, a todo in the parloops pass for function > > > transform_to_exit_first_loop: > > > ... > > > TODO: the common case is th

[PING][PATCH][PR65443] Add transform_to_exit_first_loop_alt

2015-04-15 Thread Tom de Vries
On 03-04-15 14:39, Tom de Vries wrote: On 27-03-15 15:10, Tom de Vries wrote: Hi, this patch fixes PR65443, a todo in the parloops pass for function transform_to_exit_first_loop: ... TODO: the common case is that latch of the loop is empty and immediately follows the loop exit. In this