Hi Jakub!
On 31.01.2014 15:45, Ilmir Usmanov wrote:
Hi Jakub!
Thank you for review and quick answer.
The above are OpenACC specific clauses, so they should have OACC_LIST_*?
I just followed Thomas's style recomendations:
If we're adding new names for implementing OpenACC things, maybe we
should also name these OMP_*, to keep things simple to read in the code
that uses them.
And I agree with him.
+ case OMP_LIST_DEVICE: type = "DEVICE"; break;
This one is in OpenMP 4.0 too (though, I didn't get to OpenMP 4.0 /
fortran
support yet), so this should be OMP_LIST_DEVICE.
As far as I know, OpenMP device clause requires integer-expression,
not variable-list, so, I think, we can use OMP_LIST_DEVICE to
represent OpenACC device clause.
So, what should I do? Is current naming OK? Or you think it's better to
use OACC_ prefix for OpenACC specific stuff in Fortran front-end and
OMP_ prefix in middle-end?
--
Ilmir.
