> OK.
>
> Sorry for mucking things up and making more work :(
>
Not at all. I didn't know PHIs were going to behave that way either ;-).
Thanks for the review. Committed to trunk.
Aldy
On 01/10/2018 10:45 AM, Aldy Hernandez wrote:
>>> @@ -671,11 +668,9 @@ convert_control_dep_chain_into_preds (vec
>>> *dep_chains,
>>> e = one_cd_chain[j];
>>> guard_bb = e->src;
>>> gsi = gsi_last_bb (guard_bb);
>>> + /* Ignore empty BBs as they're basically forwarder
>> @@ -671,11 +668,9 @@ convert_control_dep_chain_into_preds (vec
>> *dep_chains,
>> e = one_cd_chain[j];
>> guard_bb = e->src;
>> gsi = gsi_last_bb (guard_bb);
>> + /* Ignore empty BBs as they're basically forwarder blocks. */
>> if (gsi_end_p (gsi))
>> -
On 01/07/2018 12:32 AM, Jeff Law wrote:
On 01/06/2018 01:01 AM, Jeff Law wrote:
On 01/05/2018 01:59 PM, Aldy Hernandez wrote:
I went ahead and fixed up the empty block test, and the invalidation
code above. Bootstrapped and regression tested on x86_64. Installing
on the trunk.
Thanks.
On 01/06/2018 01:01 AM, Jeff Law wrote:
> On 01/05/2018 01:59 PM, Aldy Hernandez wrote:
>> This fixes the code that verifies that none of the uninitialized paths
>> reaching a PHI are actually taken (uninit_uses_cannot_happen).
>>
>> As discussed in the PR, this is done by fixing the predicate anal
On 01/05/2018 01:59 PM, Aldy Hernandez wrote:
> This fixes the code that verifies that none of the uninitialized paths
> reaching a PHI are actually taken (uninit_uses_cannot_happen).
>
> As discussed in the PR, this is done by fixing the predicate analysis in
> tree-ssa-uninit.c so that the set o
This fixes the code that verifies that none of the uninitialized paths
reaching a PHI are actually taken (uninit_uses_cannot_happen).
As discussed in the PR, this is done by fixing the predicate analysis in
tree-ssa-uninit.c so that the set of predicates reaching the use of a
PHI take into the
