Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

On Fri, Jan 6, 2017 at 7:00 PM, Martin Jambor wrote: > Hi, > > On Wed, Dec 14, 2016 at 01:12:11PM +0100, Richard Biener wrote: >> On Wed, Dec 14, 2016 at 11:15 AM, Martin Jambor wrote: > >> > ... > >> > +/* Emulate effects of unary OPERATION and/or conversion

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

Hi, On Wed, Dec 14, 2016 at 01:12:11PM +0100, Richard Biener wrote: > On Wed, Dec 14, 2016 at 11:15 AM, Martin Jambor wrote: > > ... > > +/* Emulate effects of unary OPERATION and/or conversion from SRC_TYPE to > > + DST_TYPE on value range in SRC_VR and store it to DST_VR.

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

On Wed, Dec 14, 2016 at 11:15 AM, Martin Jambor wrote: > Hi, > > On Fri, Dec 09, 2016 at 01:18:25PM +0100, Richard Biener wrote: >> >> The patch looks somewhat backward. It populates the param type from >> the callee but the only thing we really know is the _originating_ type >>

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

Hi, On Fri, Dec 09, 2016 at 01:18:25PM +0100, Richard Biener wrote: > > The patch looks somewhat backward. It populates the param type from > the callee but the only thing we really know is the _originating_ type > from the callers DECL_ARGUMENTS (if the JF is based on a parameter > which is

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

On Mon, Dec 12, 2016 at 8:57 AM, kugan wrote: > Hi Richard, > >>> I am fine with the new patch but you'll need an approval from Honza >>> or Richi. >>> >>> I find it a bit saddening that we cannot really rely on >>> gimple_call_fntype but at least I do not see

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

Hi Richard, I am fine with the new patch but you'll need an approval from Honza or Richi. I find it a bit saddening that we cannot really rely on gimple_call_fntype but at least I do not see any other way. The patch looks somewhat backward. It populates the param type from the callee but

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

On Fri, Dec 9, 2016 at 11:51 AM, Martin Jambor wrote: > Hi, > > On Fri, Dec 09, 2016 at 03:36:44PM +1100, kugan wrote: >> On 07/12/16 21:08, Martin Jambor wrote: >> > On Mon, Nov 28, 2016 at 04:25:00PM +1100, kugan wrote: >> > >> > ... >> > >> > > Here is a patch that does this.

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

Hi, On Fri, Dec 09, 2016 at 03:36:44PM +1100, kugan wrote: > On 07/12/16 21:08, Martin Jambor wrote: > > On Mon, Nov 28, 2016 at 04:25:00PM +1100, kugan wrote: > > > > ... > > > > > Here is a patch that does this. To fox PR78365, in > > > ipa_get_callee_param_type, I am now checking

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

Hi Martin, On 07/12/16 21:08, Martin Jambor wrote: Hello Kugan, sorry, I have lost track of this patch and re-discovered it only now. On Mon, Nov 28, 2016 at 04:25:00PM +1100, kugan wrote: Hi, On 24/11/16 19:48, Richard Biener wrote: On Wed, Nov 23, 2016 at 4:33 PM, Martin Jambor

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

Hi Martin, On 07/12/16 21:08, Martin Jambor wrote: Hello Kugan, sorry, I have lost track of this patch and re-discovered it only now. On Mon, Nov 28, 2016 at 04:25:00PM +1100, kugan wrote: Hi, On 24/11/16 19:48, Richard Biener wrote: On Wed, Nov 23, 2016 at 4:33 PM, Martin Jambor

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

Hello Kugan, sorry, I have lost track of this patch and re-discovered it only now. On Mon, Nov 28, 2016 at 04:25:00PM +1100, kugan wrote: > Hi, > > On 24/11/16 19:48, Richard Biener wrote: > > On Wed, Nov 23, 2016 at 4:33 PM, Martin Jambor wrote: > > > Hi, > > > > > > On Fri,

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

On 28 November 2016 at 10:55, kugan wrote: > Hi, > > On 24/11/16 19:48, Richard Biener wrote: >> >> On Wed, Nov 23, 2016 at 4:33 PM, Martin Jambor wrote: >>> >>> Hi, >>> >>> On Fri, Nov 18, 2016 at 12:38:18PM +1100, kugan wrote: Hi,

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

Hi, On 24/11/16 19:48, Richard Biener wrote: On Wed, Nov 23, 2016 at 4:33 PM, Martin Jambor wrote: Hi, On Fri, Nov 18, 2016 at 12:38:18PM +1100, kugan wrote: Hi, I was relying on ipa_get_callee_param_type to get type of parameter and then convert arguments to this type

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

On Thu, Nov 24, 2016 at 11:15 AM, Prathamesh Kulkarni wrote: > On 24 November 2016 at 15:23, Jan Hubicka wrote: >>> >If DECL_ARGUMENTS is not available at WPA stage then I see no other >>> >way than to put the types on the jump functions. >>> > >>>

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

On 24 November 2016 at 15:23, Jan Hubicka wrote: >> >If DECL_ARGUMENTS is not available at WPA stage then I see no other >> >way than to put the types on the jump functions. >> > >> OK. I will record the type in jump function and send a revised patch. > > It would be good to check

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

> >If DECL_ARGUMENTS is not available at WPA stage then I see no other > >way than to put the types on the jump functions. > > > OK. I will record the type in jump function and send a revised patch. It would be good to check how much of difference this makes to memory use of WPA for larger

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

Hi, On 24/11/16 19:48, Richard Biener wrote: On Wed, Nov 23, 2016 at 4:33 PM, Martin Jambor wrote: Hi, On Fri, Nov 18, 2016 at 12:38:18PM +1100, kugan wrote: Hi, I was relying on ipa_get_callee_param_type to get type of parameter and thenHi, convert arguments to this type

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

On Wed, Nov 23, 2016 at 4:33 PM, Martin Jambor wrote: > Hi, > > On Fri, Nov 18, 2016 at 12:38:18PM +1100, kugan wrote: >> Hi, >> >> I was relying on ipa_get_callee_param_type to get type of parameter and then >> convert arguments to this type while computing jump functions.

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

Hi, On Fri, Nov 18, 2016 at 12:38:18PM +1100, kugan wrote: > Hi, > > I was relying on ipa_get_callee_param_type to get type of parameter and then > convert arguments to this type while computing jump functions. However, in > cases like shown in PR78365, ipa_get_callee_param_type, instead of

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

On Fri, Nov 18, 2016 at 2:38 AM, kugan wrote: > Hi, > > I was relying on ipa_get_callee_param_type to get type of parameter and then > convert arguments to this type while computing jump functions. However, in > cases like shown in PR78365,

[PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

Hi, I was relying on ipa_get_callee_param_type to get type of parameter and then convert arguments to this type while computing jump functions. However, in cases like shown in PR78365, ipa_get_callee_param_type, instead of giving up, would return the wrong type. I think the current uses of