Re: [Patch, fortran] PR56008 (and PR47517) [F03] wrong code with lhs-realloc on assignment with derived types having allocatable components

2013-02-04 Thread Paul Richard Thomas
Committed revision 195741. Thanks for the review. Paul On 28 January 2013 22:18, Thomas Koenig tkoe...@netcologne.de wrote: Hi Paul, This patch is sufficiently straightforward that the ChangeLog entry describes it completely. The fix for both bugs lay in the nullification of the

Re: [Patch, fortran] PR56008 (and PR47517) [F03] wrong code with lhs-realloc on assignment with derived types having allocatable components

2013-01-28 Thread Paul Richard Thomas
**ping** On 23 January 2013 11:06, Tobias Burnus bur...@net-b.de wrote: Paul Richard Thomas wrote: *** gfc_alloc_allocatable_for_assignment (gf *** 8224,8229 --- 8250,8262 desc, tmp); tmp = gfc_conv_descriptor_dtype (desc);

Re: [Patch, fortran] PR56008 (and PR47517) [F03] wrong code with lhs-realloc on assignment with derived types having allocatable components

2013-01-28 Thread Thomas Koenig
Hi Paul, This patch is sufficiently straightforward that the ChangeLog entry describes it completely. The fix for both bugs lay in the nullification of the allocatable components of the newly (re)allocated array. I think this fix is OK for trunk, for the reasons you mentioned. I also think

Re: [Patch, fortran] PR56008 (and PR47517) [F03] wrong code with lhs-realloc on assignment with derived types having allocatable components

2013-01-23 Thread Tobias Burnus
Paul Richard Thomas wrote: *** gfc_alloc_allocatable_for_assignment (gf *** 8224,8229 --- 8250,8262 desc, tmp); tmp = gfc_conv_descriptor_dtype (desc); gfc_add_modify (alloc_block, tmp, gfc_get_dtype (TREE_TYPE (desc))); + if