Re: [Patch, libstdc++/68863] Let lookahead regex use captured contents

2015-12-14 Thread Jonathan Wakely
On 11/12/15 22:11 -0800, Tim Shen wrote: This is a one-line quick fix for correctness. I bootstrapped trunk and tested on x86_64-pc-linux-gnu, but I wish I can backport it at least to gcc-5-branch. I don't fully understand the patch, but it's OK for trunk, and if you're confident it's

Re: [Patch, libstdc++/68863] Let lookahead regex use captured contents

2015-12-14 Thread Tim Shen
On Mon, Dec 14, 2015 at 10:03 AM, Jonathan Wakely wrote: > OK then I do understand it and it's definitely OK to commit :-) > > Thanks. > Committed to trunk, gcc 5 and gcc 4.9. -- Regards, Tim Shen

Re: [Patch, libstdc++/68863] Let lookahead regex use captured contents

2015-12-14 Thread Tim Shen
On Mon, Dec 14, 2015 at 3:00 AM, Jonathan Wakely wrote: > I don't fully understand the patch, but it's OK for trunk, and if > you're confident it's definitely correct and safe it's OK for the > gcc-5 and gcc-4_9 branches too. > > Was it just completely wrong before, creating a

Re: [Patch, libstdc++/68863] Let lookahead regex use captured contents

2015-12-14 Thread Jonathan Wakely
On 14/12/15 09:58 -0800, Tim Shen wrote: On Mon, Dec 14, 2015 at 3:00 AM, Jonathan Wakely wrote: I don't fully understand the patch, but it's OK for trunk, and if you're confident it's definitely correct and safe it's OK for the gcc-5 and gcc-4_9 branches too. Was it just

Re: [Patch, libstdc++/68863] Let lookahead regex use captured contents

2015-12-11 Thread Tim Shen
On Fri, Dec 11, 2015 at 10:08 PM, Tim Shen wrote: > This is a one-line quick fix for correctness. > > I bootstrapped trunk and tested on x86_64-pc-linux-gnu, but I wish I > can backport it at least to gcc-5-branch. > Sorry, I didn't actually write the changelog :P. Updated.

[Patch, libstdc++/68863] Let lookahead regex use captured contents

2015-12-11 Thread Tim Shen
This is a one-line quick fix for correctness. I bootstrapped trunk and tested on x86_64-pc-linux-gnu, but I wish I can backport it at least to gcc-5-branch. Thanks! -- Regards, Tim Shen commit 46b13f280fcbec6293ad614fb8f30f5882c7106d Author: Tim Shen Date: Fri Dec 11