Hi Tobias,
> this patch broke Solaris bootstrap (both 32 and 64-bit sparc and x86):
>
> /vol/gcc/src/hg/master/local/gcc/gcc.c: In function 'bool
> check_offload_target_name(const char*, ptrdiff_t)':
> /vol/gcc/src/hg/master/local/gcc/gcc.c:4010:23: error: writing 1 byte into
> a region of size 0
On Tue, Jun 29, 2021 at 10:48 PM Rainer Orth
wrote:
> Hi Tobias,
>
> > On 29.06.21 13:58, Jakub Jelinek wrote:
> >
> >> Also, wonder if we shouldn't print the list of configured targets in
> that
> >> case, see candidates_list_and_hint functions and its callers.
> >> And it is unclear why we use
Hi Tobias,
> On 29.06.21 13:58, Jakub Jelinek wrote:
>
>> Also, wonder if we shouldn't print the list of configured targets in that
>> case, see candidates_list_and_hint functions and its callers.
>> And it is unclear why we use fatal_error, can't unknown offload target names
>> be simply ignored
On Tue, Jun 29, 2021 at 03:47:03PM +0200, Tobias Burnus wrote:
> gcc/ChangeLog:
>
> * common.opt (-foffload=): Update description.
> (-foffload-options=): New.
> * doc/invoke.texi (C Language Options): Document
> -foffload and -foffload-options.
> * gcc.c
First, the doc-sorting patch has now been applied separately as
https://gcc.gnu.org/g:d479ddc0d9854905d03a3290b203a5dcb8db07eb
On 29.06.21 13:58, Jakub Jelinek wrote:
Also, wonder if we shouldn't print the list of configured targets in that
case, see candidates_list_and_hint functions and its
On Mon, Jun 28, 2021 at 05:51:30PM +0200, Tobias Burnus wrote:
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
I think it would be better to commit the reorderings in invoke.texi
separately from the -foffload* changes, because otherwise people will keep
wondering what actually really
On 6/28/21 9:51 AM, Tobias Burnus wrote:
I managed to delete the libgomp part before posting the patch, hence,
reposted.
(The change from -foffload= to -foffload-options= ensures that also
other configured compilers such as GCN are used, an issue that Thomas
found. The original
I managed to delete the libgomp part before posting the patch, hence,
reposted.
(The change from -foffload= to -foffload-options= ensures that also
other configured compilers such as GCN are used, an issue that Thomas
found. The original -foffload=nvptx-none=-latomic was added because as
Hi Sandra, hi all,
On 19.06.21 00:47, Sandra Loosemore wrote:
Thanks. The description of the options is a lot easier to follow now,
so I mostly have only nit-picky Texinfo/grammar/terminology comments
about the docs now.
Thanks for your comments/wording suggestions.
The -f options are
On 6/17/21 5:05 PM, Tobias Burnus wrote:
On 17.06.21 23:57, Sandra Loosemore wrote:
On 6/17/21 1:40 PM, Jakub Jelinek wrote:
Could we introduce a different option which wouldn't imply enabling that
target:
-foffload-options==option
I think that works – in particular, if we do not document
On 17.06.21 23:57, Sandra Loosemore wrote:
On 6/17/21 1:40 PM, Jakub Jelinek wrote:
Could we introduce a different option which wouldn't imply enabling that
target:
-foffload-options==option
I think that works – in particular, if we do not document all
the legacy stuff but just how it should
On 6/17/21 1:40 PM, Jakub Jelinek wrote:
On Thu, Jun 17, 2021 at 09:28:00PM +0200, Tobias Burnus wrote:
I am not sure whether I fully agree with this or not. However:
Let's propose something radical, which probably won't break any real-world
code, avoids the need to add a new -foffload=
On Thu, Jun 17, 2021 at 09:28:00PM +0200, Tobias Burnus wrote:
> I am not sure whether I fully agree with this or not. However:
>
> Let's propose something radical, which probably won't break any real-world
> code, avoids the need to add a new -foffload= keyword and is
> also intuitive to the
On 17.06.21 19:50, Jakub Jelinek wrote:
On Thu, Jun 17, 2021 at 11:41:39AM -0600, Sandra Loosemore wrote:
I think it would useful to add an example with a target list and
multiple options since I think the syntax looks pretty hairy.
I fully concur that -foffload= is a mess trying to achieve
On Thu, Jun 17, 2021 at 11:41:39AM -0600, Sandra Loosemore wrote:
> On 6/17/21 10:03 AM, Tobias Burnus wrote:
>
> > Updated version – only lightly tested. I think it is
> > consistent like that and the documentation should now be
> > comprehensive. (I will have to do some additional testing.)
>
On 6/17/21 10:03 AM, Tobias Burnus wrote:
Updated version – only lightly tested. I think it is
consistent like that and the documentation should now be
comprehensive. (I will have to do some additional testing.)
Further comments and thoughts?
Hmmm, I had started to put together some
On 17.06.21 14:27, Jakub Jelinek via Gcc-patches wrote:
How does this interact with --enable-offload-defaulted ?
Well, it requires all configured offload targets, making the
installation mandatory.
I think that's fine and consistent and is as documented.
Won't -fopenmp=default=-lm force in
On Thu, Jun 17, 2021 at 02:08:07PM +0200, Tobias Burnus wrote:
> +@item -foffload=@var{offload-target-triplet}
> +@itemx -foffload=@var{offload-target-triplet}=@var{flags}
> +@itemx -foffload=@var{flags}
> +@opindex foffload
> +@cindex Offloading
> +@cindex OpenACC
> +@cindex OpenMP
> +Specifies
Hi all, this patch does two things:
(A) Documentation for -fopenmp
This finally adds documentation - which was lacking a long time but
is increasingly demanded. Often used options:
-foffload='-lm' and '-lgfortran'
-foffload=(nvptx-none=)-latomic
-foffload=(amdgcn-amdhsa=)-march=gfx906
* *
19 matches
Mail list logo
