Re: [Patch] Fortran: Add 'device_type' clause to OpenMP's declare target

2020-08-26 Thread Tobias Burnus
Thanks. I have now committed it as r11-2858-gd58e7173ef964ddac3ab3ad8cc97de8f9f3b32ee Tobias On 8/20/20 6:10 PM, Andre Vehreschild wrote: Hi Tobias, to me this looks OK now. Regards, Andre On Thu, 20 Aug 2020 11:51:50 +0200 Tobias Burnus wrote: Updated patch – taking Andre's

Re: [Patch] Fortran: Add 'device_type' clause to OpenMP's declare target

2020-08-20 Thread Andre Vehreschild
Hi Tobias, to me this looks OK now. Regards, Andre On Thu, 20 Aug 2020 11:51:50 +0200 Tobias Burnus wrote: > Updated patch – taking Andre's suggestions into account + > extending the testcase, which now catches the previous (NO)HOST > module issue. > > OK? > > Tobias > > On 8/19/20

Re: [Patch] Fortran: Add 'device_type' clause to OpenMP's declare target

2020-08-20 Thread Tobias Burnus
Updated patch – taking Andre's suggestions into account + extending the testcase, which now catches the previous (NO)HOST module issue. OK? Tobias On 8/19/20 2:51 PM, Tobias Burnus wrote: Am 18.08.20 um 19:33 schrieb Andre Vehreschild: +case OMP_DEVICE_TYPE_HOST: + MIO_NAME

Re: [Patch] Fortran: Add 'device_type' clause to OpenMP's declare target

2020-08-19 Thread Tobias Burnus
Hi Andre, thanks for the comments. Am 18.08.20 um 19:33 schrieb Andre Vehreschild: > + case OMP_DEVICE_TYPE_HOST: > + MIO_NAME (ab_attribute) (AB_OMP_DEVICE_TYPE_NOHOST, attr_bits); > Why also NOHOST here? Copy and paste error. Well spotted. Thanks! (I wonder why it didn't show up in

Re: [Patch] Fortran: Add 'device_type' clause to OpenMP's declare target

2020-08-18 Thread Andre Vehreschild
Hi Tobias, I am not deep in OMP dev, i.e., not at all, but this does not make sense to me: @@ -2397,6 +2401,22 @@ mio_symbol_attribute (symbol_attribute *attr) == OMP_REQ_ATOMIC_MEM_ORDER_RELAXED) MIO_NAME (ab_attribute) (AB_OMP_REQ_MEM_ORDER_RELAXED, attr_bits);

*PING* / Re: [Patch] Fortran: Add 'device_type' clause to OpenMP's declare target

2020-08-18 Thread Tobias Burnus
On 8/7/20 5:03 PM, Tobias Burnus wrote: This patch adds the device_type(any|nohost|host) clause for 'omp declare target' to Fortran. In OpenMP 5.0, it has no effect on variables but only on procedures – in TR8 (and later), it also affects variables. This patch adds this clause to either –

[Patch] Fortran: Add 'device_type' clause to OpenMP's declare target

2020-08-07 Thread Tobias Burnus
This patch adds the device_type(any|nohost|host) clause for 'omp declare target' to Fortran. In OpenMP 5.0, it has no effect on variables but only on procedures – in TR8 (and later), it also affects variables. This patch adds this clause to either – except that the middle end does not seem to