Re: [Ping][PATCH v3] Fix Incorrect ASan global variables alignment on arm (PR sanitizer/81697)

2017-11-30 Thread Maxim Ostapenko
Ok, thanks, here is the patch I'm going to install after bootstrap completes. On 30/11/17 14:54, Jakub Jelinek wrote: On Thu, Nov 30, 2017 at 02:38:25PM +0300, Maxim Ostapenko wrote: Hi Jakub, thanks for review. I've fixed the issues you've pointed in review. Regarding a testcase -- I've

Re: [Ping][PATCH v3] Fix Incorrect ASan global variables alignment on arm (PR sanitizer/81697)

2017-11-30 Thread Jakub Jelinek
On Thu, Nov 30, 2017 at 02:38:25PM +0300, Maxim Ostapenko wrote: > Hi Jakub, thanks for review. > > I've fixed the issues you've pointed in review. > Regarding a testcase -- I've cooked a runtime test, but it shows FP on > unpatched GCC version only when linking with Gold (because it strips >

Re: [Ping][PATCH v3] Fix Incorrect ASan global variables alignment on arm (PR sanitizer/81697)

2017-11-30 Thread Maxim Ostapenko
Hi Jakub, thanks for review. I've fixed the issues you've pointed in review. Regarding a testcase -- I've cooked a runtime test, but it shows FP on unpatched GCC version only when linking with Gold (because it strips redzones more aggressively). This patch passes tests on arm-linux and

Re: [Ping][PATCH v3] Fix Incorrect ASan global variables alignment on arm (PR sanitizer/81697)

2017-11-29 Thread Jakub Jelinek
On Tue, Nov 28, 2017 at 10:04:51AM +0300, Maxim Ostapenko wrote: > (CC'ing Jakub and Ramana) > > I would like to ping the following patch: > https://gcc.gnu.org/ml/gcc-patches/2017-10/msg02288.html > Fix Incorrect ASan global variables alignment on arm (PR sanitizer/81697) > > -Maxim >

Re: [Ping][PATCH v3] Fix Incorrect ASan global variables alignment on arm (PR sanitizer/81697)

2017-11-27 Thread Maxim Ostapenko
(CC'ing Jakub and Ramana) Hi, I would like to ping the following patch: https://gcc.gnu.org/ml/gcc-patches/2017-10/msg02288.html Fix Incorrect ASan global variables alignment on arm (PR sanitizer/81697) -Maxim gcc/ChangeLog: 2017-11-28 Maxim Ostapenko PR

[Ping][PATCH v3] Fix Incorrect ASan global variables alignment on arm (PR sanitizer/81697)

2017-11-21 Thread Maxim Ostapenko
Hi, I would like to ping the following patch: https://gcc.gnu.org/ml/gcc-patches/2017-10/msg02288.html Thanks, -Maxim gcc/ChangeLog: 2017-11-21 Maxim Ostapenko PR sanitizer/81697 * asan.c (asan_protect_global): Add new ignore_decl_rtl_set_p parameter. Return