Re: [RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-25 Thread Jeff Law
On 09/25/2017 11:25 AM, Segher Boessenkool wrote: > On Mon, Sep 25, 2017 at 10:00:55AM -0600, Jeff Law wrote: >> On 09/25/2017 04:52 AM, Segher Boessenkool wrote: >>> Did you also test Ada? It needs testing. I wanted to try it myself, >>> but your patch doesn't apply (you included the changelog

Re: [RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-25 Thread Segher Boessenkool
On Mon, Sep 25, 2017 at 10:00:55AM -0600, Jeff Law wrote: > On 09/25/2017 04:52 AM, Segher Boessenkool wrote: > > Did you also test Ada? It needs testing. I wanted to try it myself, > > but your patch doesn't apply (you included the changelog bits in the > > patch), and I cannot easily manually

Re: [RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-25 Thread Jeff Law
On 09/25/2017 08:14 AM, Segher Boessenkool wrote: > On Mon, Sep 25, 2017 at 07:41:18AM -0500, Segher Boessenkool wrote: >> On Mon, Sep 25, 2017 at 05:52:27AM -0500, Segher Boessenkool wrote: >>> Bootstrap+testsuite finished on BE, but I forgot to enable stack-clash >>> protection by default,

Re: [RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-25 Thread Jeff Law
On 09/25/2017 04:52 AM, Segher Boessenkool wrote: > >> I also flipped things so that clash protection is enabled by default and >> re-ran the tests. The idea being to see if I could exercise the path >> that uses SP_ADJUST a bit more. But that gave me the same results. >> While I think the

Re: [RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-25 Thread Jeff Law
On 09/25/2017 06:41 AM, Segher Boessenkool wrote: > On Mon, Sep 25, 2017 at 05:52:27AM -0500, Segher Boessenkool wrote: >> Bootstrap+testsuite finished on BE, but I forgot to enable stack-clash >> protection by default, whoops. Will have results later today (also LE). > > Some new failures show

Re: [RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-25 Thread Segher Boessenkool
On Mon, Sep 25, 2017 at 07:41:18AM -0500, Segher Boessenkool wrote: > On Mon, Sep 25, 2017 at 05:52:27AM -0500, Segher Boessenkool wrote: > > Bootstrap+testsuite finished on BE, but I forgot to enable stack-clash > > protection by default, whoops. Will have results later today (also LE). > >

Re: [RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-25 Thread Segher Boessenkool
On Mon, Sep 25, 2017 at 05:52:27AM -0500, Segher Boessenkool wrote: > Bootstrap+testsuite finished on BE, but I forgot to enable stack-clash > protection by default, whoops. Will have results later today (also LE). Some new failures show up: +FAIL: c-c++-common/ubsan/vla-1.c -O0 execution

Re: [RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-25 Thread Segher Boessenkool
Hi Jeff, On Fri, Sep 22, 2017 at 11:49:04AM -0600, Jeff Law wrote: > The go test suite has been run with and without this patch. I've found > os/signal seems to flip between pass and fail without rhyme or reason. > It may be related to system load. TestCgoCallbackGC now passes for > reasons

[RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-22 Thread Jeff Law
Enough changed since V3 that I think another review round on the ppc bits is warranted. wrap_frame_mem is gone. Allocation, attribute setting and notes/scheduler barriers are now in rs6000_emit_allocate_stack_1. handle_residual is gone, it's folded into rs6000_emit_allocate_stack_1.