Re: [RFA] [V3] new pass for sign/zero extension elimination

2024-01-16 Thread Jeff Law
On 1/3/24 05:07, Richard Sandiford wrote: Jeff Law writes: I know we're deep into stage3 and about to transition to stage4. So if the consensus is for this to wait, I'll understand This it the V3 of the ext-dce patch based on Joern's work from last year. Changes since V2: Handle

Re: [RFA] [V3] new pass for sign/zero extension elimination

2024-01-08 Thread Richard Sandiford
Jeff Law writes: >>> + >>> +/* Initialization of the ext-dce pass. Primarily this means >>> + setting up the various bitmaps we utilize. */ >>> + >>> +static void >>> +ext_dce_init (void) >>> +{ >>> + >> >> Nit: excess blank line. > Various nits have been fixed. I think those are all mine.

Re: [RFA] [V3] new pass for sign/zero extension elimination

2024-01-07 Thread Jeff Law
On 1/3/24 05:07, Richard Sandiford wrote: + + if (GET_CODE (x) == ZERO_EXTRACT) + { + /* If either the size or the start position is unknown, +then assume we know nothing about what is overwritten. +This is overly conservative,

Re: [RFA] [V3] new pass for sign/zero extension elimination

2024-01-05 Thread Jeff Law
On 1/4/24 13:44, Xi Ruoyao wrote: I have successfully bootstrapped and regtested the patch on loongarch64- linux-gnu. The test cases in the patch (intended for RISC-V) also works on LoongArch per my manual testing. I find myself wondering if we should create some kind of target-supports

Re: [RFA] [V3] new pass for sign/zero extension elimination

2024-01-04 Thread Xi Ruoyao
I have successfully bootstrapped and regtested the patch on loongarch64- linux-gnu. The test cases in the patch (intended for RISC-V) also works on LoongArch per my manual testing. On Mon, 2024-01-01 at 14:04 -0700, Jeff Law wrote: > I know we're deep into stage3 and about to transition to

Re: [RFA] [V3] new pass for sign/zero extension elimination

2024-01-04 Thread Jeff Law
On 1/4/24 06:36, Stefan Schulze Frielinghaus wrote: I have successfully bootstrapped and regtested the patch on s390. Out of curiosity I also ran some benchmarks which didn't show much changes except in one case which I will have to analyze further. If there is anything interesting I will

Re: [RFA] [V3] new pass for sign/zero extension elimination

2024-01-04 Thread Stefan Schulze Frielinghaus
I have successfully bootstrapped and regtested the patch on s390. Out of curiosity I also ran some benchmarks which didn't show much changes except in one case which I will have to analyze further. If there is anything interesting I will reach back to you. Cheers, Stefan On Mon, Jan 01, 2024

Re: [RFA] [V3] new pass for sign/zero extension elimination

2024-01-03 Thread Richard Sandiford
Richard Sandiford writes: > Jeff Law writes: >> [...] >> + if (GET_CODE (x) == ZERO_EXTRACT) >> +{ >> + /* If either the size or the start position is unknown, >> + then assume we know nothing about what is overwritten. >> + This is overly

Re: [RFA] [V3] new pass for sign/zero extension elimination

2024-01-03 Thread Richard Sandiford
Jeff Law writes: > I know we're deep into stage3 and about to transition to stage4. So if > the consensus is for this to wait, I'll understand > > This it the V3 of the ext-dce patch based on Joern's work from last year. > > Changes since V2: >Handle MINUS >Minor logic cleanup for

[RFA] [V3] new pass for sign/zero extension elimination

2024-01-01 Thread Jeff Law
I know we're deep into stage3 and about to transition to stage4. So if the consensus is for this to wait, I'll understand This it the V3 of the ext-dce patch based on Joern's work from last year. Changes since V2: Handle MINUS Minor logic cleanup for SUBREGs in ext_dce_process_sets