Tobias Burnus bur...@net-b.de writes:
2014-12-06 Tobias Burnus bur...@net-b.de
Manuel L³pez-Ib¡±ez m...@gcc.gnu.org
gcc/
* diagnostic.c (get_terminal_width): Renamed from getenv_columns,
removed static, and additionally use ioctl to get width.
Hello Tobias,
Thank you for this patch. I have a few comments about it below. Just
as a heads-up, I am asking questions to Manuel in there, as well as
referring to comments from FX's. Please read below.
Tobias Burnus bur...@net-b.de writes:
This patch fixes a Fortran diagnostic regression.
On 10 December 2014 at 12:10, Dodji Seketeli do...@redhat.com wrote:
Note that -fmessage-length= applies to the error message (wraps) _and_
the caret diagnostic (truncates) while the COLUMNS variable _only_
applies to the caret diagnostic. (BTW: The documentation currently
does not mention
Manuel López-Ibáñez lopeziba...@gmail.com writes:
[...]
On 10 December 2014 at 12:10, Dodji Seketeli do...@redhat.com wrote:
[...]
Manuel, was there a particular reason to avoid mentioning the COLUMNS
environment variable in the documentation?
Not that I remember. Perhaps the
So the patch you (Manual) are proposing looks fine to me, with the
environment variable taking precedence, *if* that is fine for Fortran,
of course.
That seems fine to me, from the Fortran standpoint. COLUMNS is a bit of a
special environment variable, which the shell (when it provides it)
Hi all,
I have now updated the patch, based on all comments and Manuel's patch.
And bootstrapped it on x86-64-gnu-linux. If there are no more comments,
I intent to commit it tomorrow. If it gets approved earlier, I will
commit it earlier ;-)
Some comments from me are below.
FX wrote:
So
OK. But if we rename the function, why not simply terminal_width() ?
FX
Le 6 déc. 2014 à 23:14, Tobias Burnus bur...@net-b.de a écrit :
This patch fixes a Fortran diagnostic regression.
With the current common diagnostic, the width shown with caret diagnostic is
determined by:
This patch fixes a Fortran diagnostic regression.
With the current common diagnostic, the width shown with caret
diagnostic is determined by:
case OPT_fmessage_length_:
pp_set_line_maximum_length (dc-printer, value);
diagnostic_set_caret_max_width (dc, value);
plus
