[RFC] Re: [RFC] operand_equal_p with valueization

2019-06-18 Thread Martin Liška
Hi. It's quite some time the discussion has started. Now is time for me to refresh IPA ICF and I would like integrate operand_equal_p with what I currently have in ICF (::compare_operand). I like the idea of a class that will provide both operand_equal_valueize and hash_operand_valueize. These

Re: [RFC] operand_equal_p with valueization

2015-05-27 Thread Richard Biener
On Tue, 26 May 2015, Jan Hubicka wrote: > > On Fri, 22 May 2015, Jan Hubicka wrote: > > > > > > > > > > And no, I'm hesitant to change operand_equal_p too much. It's > > > > very much deep-rooted into GENERIC. > > > > > > OK, as another option, i can bring relevant logic from operand_equal_p >

Re: [RFC] operand_equal_p with valueization

2015-05-26 Thread Jan Hubicka
> On Fri, 22 May 2015, Jan Hubicka wrote: > > > > > > > And no, I'm hesitant to change operand_equal_p too much. It's > > > very much deep-rooted into GENERIC. > > > > OK, as another option, i can bring relevant logic from operand_equal_p > > to ipa-icf and separate it into the compare_operand

Re: [RFC] operand_equal_p with valueization

2015-05-26 Thread Richard Biener
On Fri, 22 May 2015, Jan Hubicka wrote: > > > > And no, I'm hesitant to change operand_equal_p too much. It's > > very much deep-rooted into GENERIC. > > OK, as another option, i can bring relevant logic from operand_equal_p > to ipa-icf and separate it into the compare_operand class like I did

Re: [RFC] operand_equal_p with valueization

2015-05-22 Thread Jan Hubicka
> > And no, I'm hesitant to change operand_equal_p too much. It's > very much deep-rooted into GENERIC. OK, as another option, i can bring relevant logic from operand_equal_p to ipa-icf and separate it into the compare_operand class like I did. Use it in ipa-icf-gimple now and we can slowly turn

Re: [RFC] operand_equal_p with valueization

2015-05-22 Thread Richard Biener
On Fri, 22 May 2015, Jan Hubicka wrote: > Hi, > with aliasing sanity checks I got burnt again with ipa-icf-gimple's > compare_operand doing alias set checks on all types it ever trips across. > > I always tought that we do not need two equality testers - operand_equal_p and > compare_operand and

[RFC] operand_equal_p with valueization

2015-05-22 Thread Jan Hubicka
Hi, with aliasing sanity checks I got burnt again with ipa-icf-gimple's compare_operand doing alias set checks on all types it ever trips across. I always tought that we do not need two equality testers - operand_equal_p and compare_operand and given that it turns out to be non-trivial to fix issu