Re: [committed][PATCH] Trivial cleanups to new classes

2017-11-02 Thread Jeff Law
On 11/02/2017 09:33 AM, Markus Trippelsdorf wrote: On 2017.11.02 at 08:55 -0600, Jeff Law wrote: As has been discussed on-list. This patch adds a virtual destructor to the new classes in tree-ssa-propagate.h per our coding conventions and what are considered best practices. It doesn't matter

Re: [committed][PATCH] Trivial cleanups to new classes

2017-11-02 Thread Jeff Law
On 11/02/2017 09:31 AM, Richard Biener wrote: On Thu, Nov 2, 2017 at 3:55 PM, Jeff Law wrote: As has been discussed on-list. This patch adds a virtual destructor to the new classes in tree-ssa-propagate.h per our coding conventions and what are considered best practices. It

Re: [committed][PATCH] Trivial cleanups to new classes

2017-11-02 Thread Markus Trippelsdorf
On 2017.11.02 at 08:55 -0600, Jeff Law wrote: > > As has been discussed on-list. This patch adds a virtual destructor to > the new classes in tree-ssa-propagate.h per our coding conventions and > what are considered best practices. It doesn't matter for any code I'm > aware of today -- it's

Re: [committed][PATCH] Trivial cleanups to new classes

2017-11-02 Thread Richard Biener
On Thu, Nov 2, 2017 at 3:55 PM, Jeff Law wrote: > > As has been discussed on-list. This patch adds a virtual destructor to the > new classes in tree-ssa-propagate.h per our coding conventions and what are > considered best practices. It doesn't matter for any code I'm aware of

[committed][PATCH] Trivial cleanups to new classes

2017-11-02 Thread Jeff Law
As has been discussed on-list. This patch adds a virtual destructor to the new classes in tree-ssa-propagate.h per our coding conventions and what are considered best practices. It doesn't matter for any code I'm aware of today -- it's a defensive measure. This also drops the "virtual"