Re: [gomp4] reduction bug fix

2014-10-09 Thread Thomas Schwinge
Hi Cesar! On Wed, 8 Oct 2014 09:57:22 -0700, Cesar Philippidis wrote: > On 10/08/2014 02:38 AM, Thomas Schwinge wrote: > > > On Fri, 3 Oct 2014 09:22:52 -0700, Cesar Philippidis > > wrote: > >> There is a reduction bug [...] > >> This patch also includes a runtime test case. I won't apply it

Re: [gomp4] reduction bug fix

2014-10-08 Thread Cesar Philippidis
On 10/08/2014 02:38 AM, Thomas Schwinge wrote: > On Fri, 3 Oct 2014 09:22:52 -0700, Cesar Philippidis > wrote: >> There is a reduction bug [...] > > Thanks for looking into this! > >> This is a problem because initialize_reduction_data originally expected >> a GIMPLE_BIND at the very beginning

Re: [gomp4] reduction bug fix

2014-10-08 Thread Thomas Schwinge
Hi Cesar! On Fri, 3 Oct 2014 09:22:52 -0700, Cesar Philippidis wrote: > There is a reduction bug [...] Thanks for looking into this! > This is a problem because initialize_reduction_data originally expected > a GIMPLE_BIND at the very beginning of a parallel block. [...] Does your patch also

[gomp4] reduction bug fix

2014-10-03 Thread Cesar Philippidis
There is a reduction bug exposed in the following parallel block. #pragma acc parallel copy(b[0:3][0:3]) copy(l) { #pragma acc loop collapse(2) reduction(+:l) for (int i = 0; i < 2; i++) for (int j = 0; j < 2; j++) if (b[i][j] != 16) l += 1;