Hi, ok for approval?
Thanks,
-Han
On Wed, May 16, 2012 at 4:49 PM, shen...@google.com wrote:
On 2012/05/16 23:30:28, Diego Novillo wrote:
On 12-05-16 19:22 , mailto:jin...@google.com wrote:
In my opinion, gcc/ChangeLog is for upstream commits only.
It is fine that you want to port
On 12-05-17 12:27 , Han Shen(沈涵) wrote:
Hi, ok for approval?
OK.
Diego.
On 2012/05/16 01:02:26, shenhan wrote:
Hi Amhad and Jing, could you take a look at this CL at
http://codereview.appspot.com/6210060/
Thanks,
-Han
Shouldn't this have a corresponding ChangeLog entry and a
ChangeLog.google-gcc-4_6 entry?
http://codereview.appspot.com/6210060/
On 2012/05/16 17:27:59, asharif1 wrote:
On 2012/05/16 01:02:26, shenhan wrote:
Hi Amhad and Jing, could you take a look at this CL at
http://codereview.appspot.com/6210060/
Thanks,
-Han
Shouldn't this have a corresponding ChangeLog entry and a
ChangeLog.google-gcc-4_6 entry?
Hi Ahmad,
On 2012/05/16 22:11:08, shenhan wrote:
On 2012/05/16 17:27:59, asharif1 wrote:
On 2012/05/16 01:02:26, shenhan wrote:
Hi Amhad and Jing, could you take a look at this CL at
http://codereview.appspot.com/6210060/
Thanks,
-Han
Shouldn't this have a corresponding ChangeLog entry and a
In my opinion, gcc/ChangeLog is for upstream commits only.
It is fine that you want to port upstream gcc/ChangeLog as well. Just
remove your identities
+2012-05-11 Han Shen shen...@google.com
+
+ Backported r187569 from branches/google/gcc-4_6.
LGTM
On 2012/05/16 22:54:19, asharif1
On 12-05-16 19:22 , jin...@google.com wrote:
In my opinion, gcc/ChangeLog is for upstream commits only.
It is fine that you want to port upstream gcc/ChangeLog as well. Just
remove your identities
+2012-05-11 Han Shen shen...@google.com
+
+ Backported r187569 from branches/google/gcc-4_6.
The
On 2012/05/16 23:30:28, Diego Novillo wrote:
On 12-05-16 19:22 , mailto:jin...@google.com wrote:
In my opinion, gcc/ChangeLog is for upstream commits only.
It is fine that you want to port upstream gcc/ChangeLog as well.
Just
remove your identities
+2012-05-11 Han Shen
Reviewers: asharif1, jingyu,
Message:
Hi Amhad and Jing, could you take a look at this CL at
http://codereview.appspot.com/6210060/
Thanks,
-Han
Description:
Ported r187569 from google/gcc-4_6 branch.
2012-05-11 Han Shen shen...@google.com
Backport from mainline.
2012-05-01