Re: [google] Patch to enable efficient function level instrumentation (issue 5416043)

Ok for google branches when tests are done. Update ChangeLog file properly. David On Tue, Dec 20, 2011 at 1:55 PM, Harshit Chopra hars...@google.com wrote: On Fri, Dec 16, 2011 at 3:10 PM, davi...@google.com wrote: Ok, Cary's explanation makes sense. Please update the comments to make it

Re: [google] Patch to enable efficient function level instrumentation (issue 5416043)

http://codereview.appspot.com/5416043/diff/12001/gcc/config/i386/i386.c File gcc/config/i386/i386.c (left): http://codereview.appspot.com/5416043/diff/12001/gcc/config/i386/i386.c#oldcode10928 gcc/config/i386/i386.c:10928: if (current_function_decl != NULL_TREE I am not sure how the hack you

Re: [google] Patch to enable efficient function level instrumentation (issue 5416043)

http://codereview.appspot.com/5416043/diff/12001/gcc/config/i386/i386.c File gcc/config/i386/i386.c (left): http://codereview.appspot.com/5416043/diff/12001/gcc/config/i386/i386.c#oldcode10928 gcc/config/i386/i386.c:10928: if (current_function_decl != NULL_TREE If I understand correctly, this

Re: [google] Patch to enable efficient function level instrumentation (issue 5416043)

Ok, Cary's explanation makes sense. Please update the comments to make it clearer. http://codereview.appspot.com/5416043/diff/1/gcc/config/i386/i386.c File gcc/config/i386/i386.c (right): http://codereview.appspot.com/5416043/diff/1/gcc/config/i386/i386.c#newcode10927

Re: [google] Patch to enable efficient function level instrumentation (issue 5416043)

Have you uploaded the revised patch? David http://codereview.appspot.com/5416043/diff/1/gcc/config/i386/i386.c File gcc/config/i386/i386.c (right): http://codereview.appspot.com/5416043/diff/1/gcc/config/i386/i386.c#newcode10927 gcc/config/i386/i386.c:10927: + is later renamed to

Re: [google] Patch to enable efficient function level instrumentation (issue 5416043)

http://codereview.appspot.com/5416043/diff/6001/gcc/config/i386/i386.c File gcc/config/i386/i386.c (right): http://codereview.appspot.com/5416043/diff/6001/gcc/config/i386/i386.c#newcode10881 gcc/config/i386/i386.c:10881: + '_function_patch_epilogue'. The backpointer section can be used to

Re: [google] Patch to enable efficient function level instrumentation

Ping! -- Harshit

Re: [google] Patch to enable efficient function level instrumentation (issue 5416043)

Please also explain the need for backpointer section. David http://codereview.appspot.com/5416043/diff/1/gcc/config/i386/i386.c File gcc/config/i386/i386.c (right): http://codereview.appspot.com/5416043/diff/1/gcc/config/i386/i386.c#newcode10801 gcc/config/i386/i386.c:10801: +static bool Add