On Fri, 2011-04-29 at 11:18 +0800, Carrot Wei wrote:
> Yes, after porting it to google/main.
>
> Carrot
>
> On Thu, Apr 28, 2011 at 10:26 PM, Diego Novillo wrote:
> > Will you be proposing this patch for trunk as well?
> >
> >
> > Diego.
> >
At the very least a trunk version of this patch will
On Fri, Apr 29, 2011 at 01:24, Carrot Wei wrote:
>>> http://codereview.appspot.com/4433079/diff/1/gcc/hooks.c#newcode287
>>> gcc/hooks.c:287: return NULL;
>>> +hook_rtx_void_null (void)
>>> +{
>>> + return NULL;
>>>
>>> s/NULL/NULL_RTX/
>>>
>> done.
>>
> Oops. File hooks.c doesn't include rtl.h,
On Fri, Apr 29, 2011 at 11:17 AM, Carrot Wei wrote:
> On Thu, Apr 28, 2011 at 10:08 PM, wrote:
>> I only have some stylistic comments for this patch. The new pass looks
>> OK to me, but I do not know this area well enough to do a good review.
>>
>> In your ChangeLog entries, please remove the d
Ok for google/main.
David
On Thu, Apr 28, 2011 at 8:18 PM, Carrot Wei wrote:
> Yes, after porting it to google/main.
>
> Carrot
>
> On Thu, Apr 28, 2011 at 10:26 PM, Diego Novillo wrote:
>> Will you be proposing this patch for trunk as well?
>>
>>
>> Diego.
>>
>
Yes, after porting it to google/main.
Carrot
On Thu, Apr 28, 2011 at 10:26 PM, Diego Novillo wrote:
> Will you be proposing this patch for trunk as well?
>
>
> Diego.
>
On Thu, Apr 28, 2011 at 10:08 PM, wrote:
> I only have some stylistic comments for this patch. The new pass looks
> OK to me, but I do not know this area well enough to do a good review.
>
> In your ChangeLog entries, please remove the directory prefix from the
> file names.
>
done.
>
> http://
Will you be proposing this patch for trunk as well?
Diego.
I only have some stylistic comments for this patch. The new pass looks
OK to me, but I do not know this area well enough to do a good review.
In your ChangeLog entries, please remove the directory prefix from the
file names.
http://codereview.appspot.com/4433079/diff/1/gcc/hooks.c
File gcc/hoo
Hi
This patch is for google/main.
The bug http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43129 describes
how arm backend generates ineffecient code to load global variable's
address in terms of both code size and performance when option -fpic
is specified. It also describes how it can be improved by
