On 08/10/2011 11:41 PM, Sebastian Pop wrote:
Hi Tobi,
The patch looks good modulo some formatting changes:
Thanks for your review. I attached the updated patch.
I will commit this patch after the configure changes are in (and
meanwhile no further improvements were suggested for this patch).
On Thu, Aug 11, 2011 at 12:52, Tobias Grosser tob...@grosser.es wrote:
I will commit this patch after the configure changes are in (and meanwhile
no further improvements were suggested for this patch).
Ok, thanks. Let's hope we will have a configure maintainer that has some
spare cycles to go
On 08/11/2011 07:03 PM, Sebastian Pop wrote:
On Thu, Aug 11, 2011 at 12:52, Tobias Grossertob...@grosser.es wrote:
I will commit this patch after the configure changes are in (and meanwhile
no further improvements were suggested for this patch).
Ok, thanks. Let's hope we will have a
On 08/11/2011 07:16 PM, Sebastian Pop wrote:
On Thu, Aug 11, 2011 at 13:03, Sebastian Popseb...@gmail.com wrote:
On Thu, Aug 11, 2011 at 12:52, Tobias Grossertob...@grosser.es wrote:
I will commit this patch after the configure changes are in (and meanwhile
no further improvements were
On Thu, Aug 11, 2011 at 01:16:45PM -0500, Sebastian Pop wrote:
+ if (1)
+{
+ /* For now remove the isl_id's from the context before
+ translating to CLooG: this code will be removed when the
+ domain will also contain isl_id's. */
+ isl_set *context =
On Thu, Aug 11, 2011 at 14:28, Sven Verdoolaege sk...@kotnet.org wrote:
On Thu, Aug 11, 2011 at 01:16:45PM -0500, Sebastian Pop wrote:
+ if (1)
+ {
+ /* For now remove the isl_id's from the context before
+ translating to CLooG: this code will be removed when the
+ domain
On Thu, Aug 11, 2011 at 14:14, Tobias Grosser tob...@grosser.es wrote:
This needs to be adapted to my cloog.org interface patch.
I will adapt my patch set to be on top of your patch.
+/* Return an ISL identifier from the name of the ssa_name E. */
+
+static isl_id *
+isl_id_for_ssa_name
On Thu, Aug 11, 2011 at 08:14:05PM +0100, Tobias Grosser wrote:
I think the best would be to provide our ctx to cloog when allocating
the CloogState.
Yes.
skimo
On Thu, Aug 11, 2011 at 03:10:30PM -0500, Sebastian Pop wrote:
On Thu, Aug 11, 2011 at 14:28, Sven Verdoolaege sk...@kotnet.org wrote:
On Thu, Aug 11, 2011 at 01:16:45PM -0500, Sebastian Pop wrote:
+
+ /* FIXME: This function will be renamed isl_map_insert_dims and
+ documented in a
On Thu, Aug 11, 2011 at 03:23:13PM -0500, Sebastian Pop wrote:
As we are using this function only on parameters, get_name should
return a unique name. I guess that the name in isl_id is only used
for debugging purposes, as the ISL manual states that Identifiers
with the same name but
On Thu, Aug 11, 2011 at 16:00, Sven Verdoolaege sk...@kotnet.org wrote:
On Thu, Aug 11, 2011 at 03:10:30PM -0500, Sebastian Pop wrote:
On Thu, Aug 11, 2011 at 14:28, Sven Verdoolaege sk...@kotnet.org wrote:
On Thu, Aug 11, 2011 at 01:16:45PM -0500, Sebastian Pop wrote:
+
+ /* FIXME: This
+ {
+ isl_dim *dc = isl_set_get_dim (scop-context);
+ int nb_in = isl_dim_size (dc, isl_dim_set);
+ int nb_out = 1 + DR_NUM_DIMENSIONS (dr);
+ int nbp = scop_nb_params (scop);
+ isl_dim *dim = isl_dim_alloc (scop-ctx, nbp, nb_in, nb_out);
+ int i;
+
+ for (i = 0; i
On Thu, Aug 11, 2011 at 04:59:43PM -0500, Sebastian Pop wrote:
+ {
+ isl_dim *dc = isl_set_get_dim (scop-context);
+ int nb_in = isl_dim_size (dc, isl_dim_set);
+ int nb_out = 1 + DR_NUM_DIMENSIONS (dr);
+ int nbp = scop_nb_params (scop);
+ isl_dim *dim = isl_dim_alloc
Hi,
this patch moves the graphite code to the documented cloog library
interface and removes the use of old/deprecated interfaces. It ensures
that graphite will also compile flawless with future cloog.org versions.
* graphite-clast-to-gimple.c (new_clast_name_index): Store a copy
of the
Hi Tobi,
The patch looks good modulo some formatting changes:
+free(c-free_name);
+ int length = strlen(e-name);
[...]
Please follow the GNU style: there should be a space between the
function name and the open parenthesis.
- dom = new_Cloog_Domain_from_ppl_Pointset_Powerset
15 matches
Mail list logo