Re: [libitm] Remove variadic argument of _ITM_beginTransaction from libitm.h

2011-12-29 Thread Patrick Marlier
On 12/29/2011 06:59 AM, Torvald Riegel wrote: On Wed, 2011-12-28 at 21:03 -0500, Patrick Marlier wrote: With i386, the regparm(2) is not taken into account when there is a variadic function. All parameters are in the stack. Since this variable argument is never used removing it is not a

Re: [libitm] Remove variadic argument of _ITM_beginTransaction from libitm.h

2011-12-29 Thread Torvald Riegel
On Wed, 2011-12-28 at 21:03 -0500, Patrick Marlier wrote: With i386, the regparm(2) is not taken into account when there is a variadic function. All parameters are in the stack. Since this variable argument is never used removing it is not a problem. The ABI specifies beginTransaction as a

[libitm] Remove variadic argument of _ITM_beginTransaction from libitm.h

2011-12-28 Thread Patrick Marlier
With i386, the regparm(2) is not taken into account when there is a variadic function. All parameters are in the stack. Since this variable argument is never used removing it is not a problem. This solves libitm testcases memset-1.c/memcpy-1.c on i686 (part of PR51655/51124). Before: FAIL: