Re: [libquadmath, patch, committed] Fix exponent reading

2012-12-04 Thread David Edelsohn
Tobias, The quad_3.f90 testcase fails on AIX, which does not have quad math enabled. I do not understand how the following line can be correct. Fortran does not have early exit and the line is evaluated at compile time, so real_kinds(3) is not valid because real_kinds array does not have that

Re: [libquadmath, patch, committed] Fix exponent reading

2012-12-04 Thread Tobias Burnus
David Edelsohn: The quad_3.f90 testcase fails on AIX, which does not have quad math enabled. I do not understand how the following line can be correct. Well, obviously, it is not correct - otherwise you wouldn't see a failure :-) Corrected by the attached patch (Rev. 194155). Sorry for the

Re: [libquadmath, patch, committed] Fix exponent reading

2012-12-04 Thread David Edelsohn
Tobias, I have not tried this patch, but will it actually fix it? The error is real_kinds(3) is outside the array bounds. Your patch fixes addresses a runtime problem, not a compile-time problem, if I understand correctly. /nasfarm/dje/src/src/gcc/testsuite/gfortran.dg/quad_3.f90:17.47: if

Re: [libquadmath, patch, committed] Fix exponent reading

2012-12-04 Thread Jakub Jelinek
On Tue, Dec 04, 2012 at 05:03:10PM +0100, Tobias Burnus wrote: +2012-12-04 Tobias Burnus bur...@net-b.de + + * gfortran.dg/quad_3.f90: Fix a condition, + which wrongly required ordered/lazy evaluation. + 2012-12-04 Marcus Shawcroft marcus.shawcr...@arm.com *

Re: [libquadmath, patch, committed] Fix exponent reading

2012-12-04 Thread Tobias Burnus
David Edelsohn wrote: I have not tried this patch, but will it actually fix it? The error is real_kinds(3) is outside the array bounds. Your patch fixes addresses a runtime problem, not a compile-time problem, if I understand correctly. Yes, I realized it myself - after a hint by Dominique.

[libquadmath, patch, committed] Fix exponent reading

2012-12-03 Thread Tobias Burnus
Somehow that got lot when updating the file. I think, we really need a proper test suite - the current quad_{1,2,3}.f90 are a first step, but rather incomplete. Committed as Rev. 194100 after build+regtesting. Tobias Index: libquadmath/ChangeLog