Re: [patch, fortran] Fix PR 89174, segfault on allocate with MOLD

2019-02-25 Thread Steve Kargl
On Mon, Feb 25, 2019 at 01:58:27PM -0800, Steve Kargl wrote: > On Mon, Feb 25, 2019 at 10:03:29PM +0100, Thomas König wrote: > > Hi Steve, > > > > >> I think this was introduced quite some time ago, not sure if it > > >> was ever documented anywhere. I guess we should do so. > > >> > > >

Re: [patch, fortran] Fix PR 89174, segfault on allocate with MOLD

2019-02-25 Thread Steve Kargl
On Mon, Feb 25, 2019 at 10:03:29PM +0100, Thomas König wrote: > Hi Steve, > > >> I think this was introduced quite some time ago, not sure if it > >> was ever documented anywhere. I guess we should do so. > >> > > Probably want to document this in the testcase. > > I just checked and found 77

Re: [patch, fortran] Fix PR 89174, segfault on allocate with MOLD

2019-02-25 Thread Thomas König
Hi Steve, I think this was introduced quite some time ago, not sure if it was ever documented anywhere. I guess we should do so. Probably want to document this in the testcase. I just checked and found 77 occurences in the test suite (most of them mine, to be sure). So, maybe an entry in

Re: [patch, fortran] Fix PR 89174, segfault on allocate with MOLD

2019-02-25 Thread Steve Kargl
On Mon, Feb 25, 2019 at 07:15:32PM +0100, Thomas Koenig wrote: > Hi Dominique, > > > I see a double space in > > > > ! { dg-do run } > > > > Is this intended? > > Yes, it is. This is for tests which should not be run with all > the options cycling, but only once. > > I think this was

Re: [patch, fortran] Fix PR 89174, segfault on allocate with MOLD

2019-02-25 Thread Thomas Koenig
Hi Dominique, I see a double space in ! { dg-do run } Is this intended? Yes, it is. This is for tests which should not be run with all the options cycling, but only once. I think this was introduced quite some time ago, not sure if it was ever documented anywhere. I guess we should do

Re: [patch, fortran] Fix PR 89174, segfault on allocate with MOLD

2019-02-25 Thread Dominique d'Humières
Hi Thomas, I see a double space in ! { dg-do run } Is this intended? If yes, it should probably be documented, otherwise it should be fixed. TIA Dominique

Re: [patch, fortran] Fix PR 89174, segfault on allocate with MOLD

2019-02-24 Thread Steve Kargl
On Sun, Feb 24, 2019 at 05:42:14PM +, Paul Richard Thomas wrote: > > > Of course, there could also be a more profound way of fixing this > > bug :-) > > I wish that it were the case. I am unable to decide whether the design > choices made for an F95 compiler have cause the add-ons to be >

Re: [patch, fortran] Fix PR 89174, segfault on allocate with MOLD

2019-02-24 Thread Paul Richard Thomas
Hi Thomas, > Of course, there could also be a more profound way of fixing this > bug :-) I wish that it were the case. I am unable to decide whether the design choices made for an F95 compiler have cause the add-ons to be intrinsically complicated or whether or whether F2018, extensions and

[patch, fortran] Fix PR 89174, segfault on allocate with MOLD

2019-02-24 Thread Thomas Koenig
Hello world, the attached patch fixes a regression where a segfault occured at runtime for the attached test case. The regression made it out into the wild with the 8.3 release. Unfortunately, it was discovered too late before release to do anything about it. In effect, this patch reverts a