Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-12 Thread Jakub Jelinek
On Thu, Apr 12, 2018 at 11:14:45PM +0200, Thomas Koenig wrote: > 2018-04-12 Thomas Koenig > > PR fortran/83064 > PR testsuite/85346 > * trans-stmt.c (gfc_trans_forall_loop): Use annot_expr_ivdep_kind > for annotation and remove dependence on

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-12 Thread Thomas Koenig
Well, here's a variation which actually passes regression-test. Seems I implicitly believed that the implicit save on main program variables actually works... well, it turns out that it doesn't, which is now PR85364. OK for trunk? Thomas 2018-04-12 Thomas Koenig

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-12 Thread Jakub Jelinek
On Wed, Apr 11, 2018 at 09:47:22PM +0200, Thomas Koenig wrote: > Am 11.04.2018 um 20:33 schrieb Jakub Jelinek: > > > > I have attached updated patch which moves the test case to > > > gfortran.dg/gomp (where it actually passes). > > > > How could it pass there? dg-do run tests don't belong into

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-11 Thread Thomas Koenig
Am 11.04.2018 um 20:33 schrieb Jakub Jelinek: I have attached updated patch which moves the test case to gfortran.dg/gomp (where it actually passes). How could it pass there? dg-do run tests don't belong into g*.dg/gomp/, nothing adds the -B etc. options needed to find libgomp.spec or

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-11 Thread Jakub Jelinek
On Wed, Apr 11, 2018 at 08:18:35PM +0200, Thomas Koenig wrote: > Am 11.04.2018 um 17:44 schrieb Jakub Jelinek: > > On Tue, Apr 10, 2018 at 11:50:44PM +0200, Thomas Koenig wrote: > > > Hi Jakub, > > > > > > > > > > The new test FAILs everywhere, gfortran.dg doesn't have infrastructure > > > > to

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-11 Thread Thomas Koenig
Am 11.04.2018 um 17:44 schrieb Jakub Jelinek: On Tue, Apr 10, 2018 at 11:50:44PM +0200, Thomas Koenig wrote: Hi Jakub, The new test FAILs everywhere, gfortran.dg doesn't have infrastructure to run -fopenmp, -fopenacc nor -ftree-parallelize-loops= tests. You need to put such tests into

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-11 Thread Jakub Jelinek
On Tue, Apr 10, 2018 at 11:50:44PM +0200, Thomas Koenig wrote: > Hi Jakub, > > > > The new test FAILs everywhere, gfortran.dg doesn't have infrastructure to > > run -fopenmp, -fopenacc nor -ftree-parallelize-loops= tests. > > You need to put such tests into libgomp/testsuite/libgomp.fortran/ >

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-10 Thread Thomas Koenig
Hi Jakub, The new test FAILs everywhere, gfortran.dg doesn't have infrastructure to run -fopenmp, -fopenacc nor -ftree-parallelize-loops= tests. You need to put such tests into libgomp/testsuite/libgomp.fortran/ I put the test case in the attached form into the libgomp.fortran directory, but

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-10 Thread Jakub Jelinek
On Mon, Apr 09, 2018 at 10:58:13PM +0200, Thomas Koenig wrote: > 2018-04-09 Thomas Koenig > > PR fortran/83064 > * trans-stmt.c (gfc_trans_forall_loop): Remove annotation for > parallell processing of DO CONCURRENT -ftree-parallelize-loops >

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-10 Thread Richard Biener
On Mon, Apr 9, 2018 at 10:58 PM, Thomas Koenig wrote: > Hi Steve, > >> On Mon, Apr 09, 2018 at 10:10:13PM +0200, Thomas Koenig wrote: >>> >>> >>> the attached patch removes the parallel annotation from DO CONCURRENT. >>> As discussed in the PR, the autoparallellizer

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-09 Thread Steve Kargl
On Mon, Apr 09, 2018 at 10:58:13PM +0200, Thomas Koenig wrote: > > On Mon, Apr 09, 2018 at 10:10:13PM +0200, Thomas Koenig wrote: > >> > >> the attached patch removes the parallel annotation from DO CONCURRENT. > >> As discussed in the PR, the autoparallellizer currently generates > >> wrong code.

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-09 Thread Thomas Koenig
Hi Steve, On Mon, Apr 09, 2018 at 10:10:13PM +0200, Thomas Koenig wrote: the attached patch removes the parallel annotation from DO CONCURRENT. As discussed in the PR, the autoparallellizer currently generates wrong code. The only feasible way is to disable the annotation for gcc-8 and work

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-09 Thread Steve Kargl
On Mon, Apr 09, 2018 at 10:10:13PM +0200, Thomas Koenig wrote: > > the attached patch removes the parallel annotation from DO CONCURRENT. > As discussed in the PR, the autoparallellizer currently generates > wrong code. The only feasible way is to disable the annotation for > gcc-8 and work on

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-09 Thread Jakub Jelinek
On Mon, Apr 09, 2018 at 10:10:13PM +0200, Thomas Koenig wrote: > Hello world, > > the attached patch removes the parallel annotation from DO CONCURRENT. > As discussed in the PR, the autoparallellizer currently generates > wrong code. The only feasible way is to disable the annotation for > gcc-8

[patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-09 Thread Thomas Koenig
Hello world, the attached patch removes the parallel annotation from DO CONCURRENT. As discussed in the PR, the autoparallellizer currently generates wrong code. The only feasible way is to disable the annotation for gcc-8 and work on the wrong-code issues for gcc-9. This is an 8 regression.