[libgomp, testsuite] Don't shadow global 'offload_targets' variable (was: [patch, libgomp] Add tests for print from offload target)

2021-05-18 Thread Thomas Schwinge
Hi! On 2019-11-27T18:54:45+0100, I wrote: > On 2019-11-14T18:22:39+0100, Jakub Jelinek wrote: >> On Thu, Nov 14, 2019 at 05:18:41PM +, Andrew Stubbs wrote: >>> On 14/11/2019 17:05, Jakub Jelinek wrote: >>> > On Thu, Nov 14, 2019 at 04:47:49PM +, Andrew Stubbs wrote: >>> > > This patch [..

Re: [patch, libgomp] Add tests for print from offload target

2019-11-27 Thread Thomas Schwinge
Hi! On 2019-11-14T18:22:39+0100, Jakub Jelinek wrote: > On Thu, Nov 14, 2019 at 05:18:41PM +, Andrew Stubbs wrote: >> On 14/11/2019 17:05, Jakub Jelinek wrote: >> > On Thu, Nov 14, 2019 at 04:47:49PM +, Andrew Stubbs wrote: >> > > This patch adds new libgomp tests to ensure that C "printf

Re: [patch, libgomp] Add tests for print from offload target

2019-11-14 Thread Jakub Jelinek
On Thu, Nov 14, 2019 at 05:18:41PM +, Andrew Stubbs wrote: > On 14/11/2019 17:05, Jakub Jelinek wrote: > > On Thu, Nov 14, 2019 at 04:47:49PM +, Andrew Stubbs wrote: > > > This patch adds new libgomp tests to ensure that C "printf" and Fortran > > > "write" work correctly within offload ker

Re: [patch, libgomp] Add tests for print from offload target

2019-11-14 Thread Andrew Stubbs
On 14/11/2019 17:05, Jakub Jelinek wrote: On Thu, Nov 14, 2019 at 04:47:49PM +, Andrew Stubbs wrote: This patch adds new libgomp tests to ensure that C "printf" and Fortran "write" work correctly within offload kernels. Both should work for amdgcn, but nvptx uses the libgfortran "minimal" mo

Re: [patch, libgomp] Add tests for print from offload target

2019-11-14 Thread Tobias Burnus
On 11/14/19 5:47 PM, Andrew Stubbs wrote: This patch adds new libgomp tests to ensure that C "printf" and Fortran "write" work correctly within offload kernels. Both should work for amdgcn, but nvptx uses the libgfortran "minimal" mode which lacks "write" support. Can't you add something like

Re: [patch, libgomp] Add tests for print from offload target

2019-11-14 Thread Jakub Jelinek
On Thu, Nov 14, 2019 at 04:47:49PM +, Andrew Stubbs wrote: > This patch adds new libgomp tests to ensure that C "printf" and Fortran > "write" work correctly within offload kernels. Both should work for amdgcn, > but nvptx uses the libgfortran "minimal" mode which lacks "write" support. So, do

[patch, libgomp] Add tests for print from offload target

2019-11-14 Thread Andrew Stubbs
Hi, This patch adds new libgomp tests to ensure that C "printf" and Fortran "write" work correctly within offload kernels. Both should work for amdgcn, but nvptx uses the libgfortran "minimal" mode which lacks "write" support. Obviously, printing from offload kernels is not recommended in p