Re: [patch][RFC] bail out after front-end errors

2013-01-02 Thread Richard Biener
On Fri, Dec 28, 2012 at 6:35 PM, Steven Bosscher stevenb@gmail.com wrote: On Tue, Mar 27, 2012 at 10:59 AM, Richard Guenther wrote: On Tue, Mar 27, 2012 at 10:32 AM, Steven Bosscher wrote: On Tue, Mar 27, 2012 at 9:17 AM, Richard Guenther wrote: It would be nice to finally move the call

Re: [patch][RFC] bail out after front-end errors

2012-12-28 Thread Steven Bosscher
On Tue, Mar 27, 2012 at 10:59 AM, Richard Guenther wrote: On Tue, Mar 27, 2012 at 10:32 AM, Steven Bosscher wrote: On Tue, Mar 27, 2012 at 9:17 AM, Richard Guenther wrote: It would be nice to finally move the call to cgraph_finalize_compilation_unit to the middle-end ... (warning, if you try

Re: [patch][RFC] bail out after front-end errors

2012-03-27 Thread Richard Guenther
On Mon, Mar 26, 2012 at 10:56 PM, Steven Bosscher stevenb@gmail.com wrote: Hello, This patch is one way to address PR44982. I see no good reason to cgraph_finalize_compilation_unit if there were parse errors. As Richi already pointed out, GCC traditionally has proceeded after parse

Re: [patch][RFC] bail out after front-end errors

2012-03-27 Thread Paolo Carlini
Hi, On Mon, Mar 26, 2012 at 10:56 PM, Steven Bosscherstevenb@gmail.com wrote: Hello, This patch is one way to address PR44982. I see no good reason to cgraph_finalize_compilation_unit if there were parse errors. As Richi already pointed out, GCC traditionally has proceeded after parse

Re: [patch][RFC] bail out after front-end errors

2012-03-27 Thread Mike Stump
On Mar 26, 2012, at 1:56 PM, Steven Bosscher wrote: This patch is one way to address PR44982. That's a great idea, I like it. There is only one problem that I know of that prevents it from going in now. We emit errors/warnings from below finalize and there is a feature in which we emit all

Re: [patch][RFC] bail out after front-end errors

2012-03-27 Thread Steven Bosscher
On Tue, Mar 27, 2012 at 8:59 PM, Mike Stump mikest...@comcast.net wrote: and errors from the middle end are mostly for exotic code (involving asm()s and the like). Bailing out after parse errors is therefore IMHO the right thing to do for the common case. Some are for very exotic things, yes,

[patch][RFC] bail out after front-end errors

2012-03-26 Thread Steven Bosscher
Hello, This patch is one way to address PR44982. I see no good reason to cgraph_finalize_compilation_unit if there were parse errors. As Richi already pointed out, GCC traditionally has proceeded after parse errors to preserve warnings and errors we generate from the middle-end and during