Re: [patch][rtl-optimization][i386][pr97777] Fix a reg-stack df maintenance bug triggered by zero-call-used-regs pass.

Thanks a lot for your review. I will commit the patch soon. Qing > On Dec 2, 2020, at 12:27 PM, Jeff Law wrote: > > > > On 12/2/20 9:32 AM, Qing Zhao wrote: >> >>> So we are clearing the x87 registers with that option. Hence the change >>> in reg-stack behavior. I'm a bit surprised by

Re: [patch][rtl-optimization][i386][pr97777] Fix a reg-stack df maintenance bug triggered by zero-call-used-regs pass.

On 12/2/20 9:32 AM, Qing Zhao wrote: > >> So we are clearing the x87 registers with that option. Hence the change >> in reg-stack behavior. I'm a bit surprised by this as I don't see >> clearing the x87 registers as particularly helpful from a security >> standpoint. But I haven't followed

Re: [patch][rtl-optimization][i386][pr97777] Fix a reg-stack df maintenance bug triggered by zero-call-used-regs pass.

> On Dec 1, 2020, at 6:16 PM, Jeff Law wrote: From c2573c6c8552b7b4c2eedb0684ce48b5c11436ec Mon Sep 17 00:00:00 2001 From: qing zhao Date: Thu, 19 Nov 2020 16:46:50 +0100 Subject: [PATCH] rtl-optimization: Fix data flow maintenance bug in reg-stack.c [pr9]

Re: [patch][rtl-optimization][i386][pr97777] Fix a reg-stack df maintenance bug triggered by zero-call-used-regs pass.

On 11/30/20 1:50 PM, Qing Zhao wrote: > Hi, Jeff, > > Sorry for the late reply due to thanksgiving long weekend.  > >> On Nov 25, 2020, at 1:37 PM, Jeff Law > > wrote: >> >> >> >> On 11/19/20 8:59 AM, Qing Zhao via Gcc-patches wrote: >>> Hi,  >>> >>> PR9 - ICE: in

Re: [patch][rtl-optimization][i386][pr97777] Fix a reg-stack df maintenance bug triggered by zero-call-used-regs pass.

Hi, Jeff, Sorry for the late reply due to thanksgiving long weekend. > On Nov 25, 2020, at 1:37 PM, Jeff Law wrote: > > > > On 11/19/20 8:59 AM, Qing Zhao via Gcc-patches wrote: >> Hi, >> >> PR9 - ICE: in df_refs_verify, at df-scan.c:3991 with -O >> -ffinite-math-only

Re: [patch][rtl-optimization][i386][pr97777] Fix a reg-stack df maintenance bug triggered by zero-call-used-regs pass.

On 11/19/20 8:59 AM, Qing Zhao via Gcc-patches wrote: > Hi, > > PR9 - ICE: in df_refs_verify, at df-scan.c:3991 with -O > -ffinite-math-only -fzero-call-used-regs=all > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=9 > > Is a bug triggered by the new pass zero-call-used-regs,

[patch][rtl-optimization][i386][pr97777] Fix a reg-stack df maintenance bug triggered by zero-call-used-regs pass.

Hi, PR9 - ICE: in df_refs_verify, at df-scan.c:3991 with -O -ffinite-math-only -fzero-call-used-regs=all https://gcc.gnu.org/bugzilla/show_bug.cgi?id=9 Is a bug triggered by the new pass zero-call-used-regs, however, it’s an old bug in the pass “reg-stack”. This pass does not