Re: [patch] Fix PR59295 -- remove useless warning

2014-03-21 Thread Fabien ChĂȘne
2014-03-21 1:33 GMT+01:00 Paul Pluzhnikov ppluzhni...@google.com: Greetings, Attached patch deletes code to warn about repeated friend declaration. Why not making this warning suppressable, instead of removing it ? Shouldn't it fall under -W(no)-redundant-decls ? -- Fabien

Re: [patch] Fix PR59295 -- remove useless warning

2014-03-21 Thread Paul Pluzhnikov
On Fri, Mar 21, 2014 at 1:58 AM, Fabien ChĂȘne fabien.ch...@gmail.com wrote: Why not making this warning suppressable, instead of removing it ? Shouldn't it fall under -W(no)-redundant-decls ? Thanks. I'll revise the patch to do that. -- Paul Pluzhnikov

[patch] Fix PR59295 -- remove useless warning

2014-03-20 Thread Paul Pluzhnikov
Greetings, Attached patch deletes code to warn about repeated friend declaration. The warning has apparently been present since at least 1997, but it's unlikely to have ever prevented any actual bugs. Ok for trunk once it opens in stage1? Tested on Linux/x86_64 with no regressions. Thanks,