Re: [patch] Hide the caret for -Wstack-usage

2014-07-19 Thread Eric Botcazou
I personally don't like much this pattern of saving a variable, doing something and then restoring it. Right, it's kludgy, so I have only changed the location in the end. Tested on x86_64-suse-linux, applied on all active branches as obvious. 2014-07-19 Eric Botcazou ebotca...@adacore.com

Re: [patch] Hide the caret for -Wstack-usage

2014-07-12 Thread Eric Botcazou
Your patch hides the caret but the location still points to the closing brace (so if you use an IDE like emacs this is where you will go). Is there a location for the definition? Could we store/pass one to this point? Otherwise, would it be appropriate to point to the declaration of the

Re: [patch] Hide the caret for -Wstack-usage

2014-07-12 Thread Manuel López-Ibáñez
On 12 July 2014 03:39, Eric Botcazou ebotca...@adacore.com wrote: Your patch hides the caret but the location still points to the closing brace (so if you use an IDE like emacs this is where you will go). Is there a location for the definition? Could we store/pass one to this point?

[patch] Hide the caret for -Wstack-usage

2014-07-10 Thread Eric Botcazou
Hi, since displaying the caret was made the default, the -Wstack-usage warning has a strange-looking final part: stack-usage-2.c: In function 'foo2': stack-usage-2.c:16:1: warning: stack usage is 920 bytes [-Wstack-usage=] } ^ Tested on x86_64-suse-linux, OK for all active branches?

RE: [patch] Hide the caret for -Wstack-usage

2014-07-10 Thread Manuel López-Ibáñez
since displaying the caret was made the default, the -Wstack-usage warning has a strange-looking final part: stack-usage-2.c: In function 'foo2': stack-usage-2.c:16:1: warning: stack usage is 920 bytes [-Wstack-usage=] } ^ Your patch hides the caret but the location still points to the