Re: [patch] More precise message with -Winline

2019-07-25 Thread Eric Botcazou
> That seems misleading, unless the exception is really never thrown. See my earlier answer to Richard. -- Eric Botcazou

Re: [patch] More precise message with -Winline

2019-07-25 Thread Andi Kleen
Eric Botcazou writes: > Hi, > > for EH cleanups, the branch probability heuristics can consider that edges > are > never taken, i.e. their profile count is set to zero. In this case, no > matter > how you tweak the inlining parameters, you cannot get function calls inlined, > but -Winline n

Re: [patch] More precise message with -Winline

2019-07-24 Thread Eric Botcazou
> Looks good besides > > + if (e->count.ipa () == profile_count::zero ()) > + e->inline_failed = CIF_NEVER_CALL; > > does it actually matter what kind of profile quality e->count.ipa has > compared to profile_count::zero ()? I don't really know, the other examples in the functi

Re: [patch] More precise message with -Winline

2019-07-24 Thread Richard Biener
On Wed, Jul 24, 2019 at 11:29 AM Eric Botcazou wrote: > > Hi, > > for EH cleanups, the branch probability heuristics can consider that edges are > never taken, i.e. their profile count is set to zero. In this case, no matter > how you tweak the inlining parameters, you cannot get function calls i

[patch] More precise message with -Winline

2019-07-24 Thread Eric Botcazou
Hi, for EH cleanups, the branch probability heuristics can consider that edges are never taken, i.e. their profile count is set to zero. In this case, no matter how you tweak the inlining parameters, you cannot get function calls inlined, but -Winline nevertheless prints the standard message a